Closed
Bug 1269738
Opened 9 years ago
Closed 9 years ago
Lock nsHttpRequestHead::SetHeader
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: dragana, Assigned: dragana)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
1.03 KB,
patch
|
mcmanus
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I forgot to lock SetHeader :)
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8748154 -
Flags: review?(mcmanus)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=618d18461abc
Updated•9 years ago
|
Attachment #8748154 -
Flags: review?(mcmanus) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7d557a4bf9ac
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8748154 [details] [diff] [review] bug_lockSetHeader.patch Approval Request Comment [Feature/regressing bug #]: Needed for uplift of bug 1247982 [User impact if declined]: [Describe test coverage new/current, TreeHerder]: [Risks and why]: No risk it is one line patch [String/UUID change made/needed]: Order of uplift: bug 1247982, this patch, bug 1274509
Attachment #8748154 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox48:
--- → affected
Comment 6•8 years ago
|
||
Comment on attachment 8748154 [details] [diff] [review] bug_lockSetHeader.patch This is for 48 beta
Attachment #8748154 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment 7•8 years ago
|
||
Comment on attachment 8748154 [details] [diff] [review] bug_lockSetHeader.patch Review of attachment 8748154 [details] [diff] [review]: ----------------------------------------------------------------- This patch fixed lock for SetHeader. Take it in 48 beta 3.
Attachment #8748154 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•8 years ago
|
||
Comment on attachment 8748154 [details] [diff] [review] bug_lockSetHeader.patch Review of attachment 8748154 [details] [diff] [review]: ----------------------------------------------------------------- Need to take a close look at 3 bugs.
Attachment #8748154 -
Flags: approval-mozilla-beta+ → approval-mozilla-beta?
Comment 9•8 years ago
|
||
Comment on attachment 8748154 [details] [diff] [review] bug_lockSetHeader.patch Take it for the bug 1247982 Should be in 48 beta 3
Attachment #8748154 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/b142c2e3bf73
You need to log in
before you can comment on or make changes to this bug.
Description
•