Closed Bug 1269928 Opened 9 years ago Closed 9 years ago

Simple, less-complexifying proxy-handler code cleanups

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(2 files)

Fold DirectProxyHandler into Wrapper, which is now its only (non-test) consumer
40.14 KB, patch
efaust
: review+
Details | Diff | Splinter Review
Rename ScriptedDirectProxyHandler to ScriptedProxyHandler now that DPH is gone (and SDPH hasn't even inherited from DPH in ages)
30.39 KB, patch
efaust
: review+
Details | Diff | Splinter Review
No description provided.
Comment on attachment 8748420 [details] [diff] [review] Fold DirectProxyHandler into Wrapper, which is now its only (non-test) consumer Review of attachment 8748420 [details] [diff] [review]: ----------------------------------------------------------------- I'm unhappy about removing that test. Why can't we just make the thing inherit from Wrapper instead of DirectProxyHandler, and leave everything else the same? r=me with at least trying that.
Attachment #8748420 - Flags: review?(efaustbmo) → review+
Attachment #8748421 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/1d72d5a56b14 https://hg.mozilla.org/mozilla-central/rev/8a037cb33a3d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: