Closed
Bug 1270038
Opened 9 years ago
Closed 8 years ago
Add permission 'persistent-storage' for StorageManager
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: shawnjohnjr, Assigned: shawnjohnjr)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: btpp-active,[storage-v1])
Attachments
(1 file, 2 obsolete files)
|
3.52 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Add permission 'persistent-storage'
|
||
Comment 1•9 years ago
|
||
I'm guessing you're planning on working on this soon, Shawn, so I'm marking as 'fixlater'. Feel free to correct that.
Whiteboard: btpp-fixlater
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → shuang
|
|
Assignee | |
Comment 2•9 years ago
|
||
Based on https://w3c.github.io/permissions/#persistent-storage.
"persistent-storage" permission allows an origin to make its site storage unit contain a persistent box. "persistent-storage" is a boolean feature.
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: btpp-fixlater → btpp-active
|
||
Updated•8 years ago
|
Whiteboard: btpp-active → btpp-active,storage-v1
|
|
Assignee | |
Comment 3•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8814885 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•8 years ago
|
||
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8815157 [details] [diff] [review]
Bug 1270038 - Add permission 'persistent-storage' for StorageManager
Hi baku,
This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'.
[1] https://w3c.github.io/permissions/#permission-registry
[2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage
Attachment #8815157 -
Flags: review?(amarchesini)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8815157 -
Attachment is obsolete: true
Attachment #8815157 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 6•8 years ago
|
||
Oh. I just found test_permissions_api.html also copied to browser/components/originattributes/test/mochitest/test_permissions_api.html. I should also modify this test case.
|
|
Assignee | |
Comment 7•8 years ago
|
||
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8815169 [details] [diff] [review]
Bug 1270038 - Add permission 'persistent-storage' for StorageManager
Hi baku,
This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'.
[1] https://w3c.github.io/permissions/#permission-registry
[2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage
I also tested this patch with patches on bug 1286717. It looks good.
Attachment #8815169 -
Flags: review?(amarchesini)
|
||
Updated•8 years ago
|
Attachment #8815169 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 9•8 years ago
|
||
|
||
Comment 10•8 years ago
|
||
Pushed by shuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4c27ba3875
Add permission 'persistent-storage' for StorageManager, r=baku
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•8 years ago
|
Keywords: dev-doc-needed
|
||
Updated•8 years ago
|
Whiteboard: btpp-active,storage-v1 → btpp-active,[storage-v1]
|
||
Comment 12•8 years ago
|
||
I've documented this.
I've added details of the new permission name and updated browser support info on relevant pages:
https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API
https://developer.mozilla.org/en-US/docs/Web/API/Permissions
https://developer.mozilla.org/en-US/docs/Web/API/Permissions/revoke
https://developer.mozilla.org/en-US/docs/Web/API/Permissions/query
I've also added a note to the Fx53 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM
Let me know if this looks OK - thanks!
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•