Add permission 'persistent-storage' for StorageManager

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

Tracking

(Blocks 1 bug, {dev-doc-complete})

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: btpp-active,[storage-v1])

Attachments

(1 attachment, 2 obsolete attachments)

Add permission 'persistent-storage'
I'm guessing you're planning on working on this soon, Shawn, so I'm marking as 'fixlater'. Feel free to correct that.
Whiteboard: btpp-fixlater
Assignee: nobody → shuang
Based on https://w3c.github.io/permissions/#persistent-storage.
"persistent-storage" permission allows an origin to make its site storage unit contain a persistent box. "persistent-storage" is a boolean feature.
Whiteboard: btpp-fixlater → btpp-active
Whiteboard: btpp-active → btpp-active,storage-v1
Comment on attachment 8815157 [details] [diff] [review]
Bug 1270038 - Add permission 'persistent-storage' for StorageManager

Hi baku,
This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'.


[1] https://w3c.github.io/permissions/#permission-registry
[2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage
Attachment #8815157 - Flags: review?(amarchesini)
Attachment #8815157 - Attachment is obsolete: true
Attachment #8815157 - Flags: review?(amarchesini)
Oh. I just found test_permissions_api.html also copied to browser/components/originattributes/test/mochitest/test_permissions_api.html. I should also modify this test case.
Comment on attachment 8815169 [details] [diff] [review]
Bug 1270038 - Add permission 'persistent-storage' for StorageManager

Hi baku,
This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'.


[1] https://w3c.github.io/permissions/#permission-registry
[2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage

I also tested this patch with patches on bug 1286717. It looks good.
Attachment #8815169 - Flags: review?(amarchesini)
Attachment #8815169 - Flags: review?(amarchesini) → review+

Comment 10

2 years ago
Pushed by shuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4c27ba3875
Add permission 'persistent-storage' for StorageManager, r=baku

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e4c27ba3875
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

2 years ago
Blocks: 1309123
Whiteboard: btpp-active,storage-v1 → btpp-active,[storage-v1]
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.