Closed
Bug 1270038
Opened 8 years ago
Closed 7 years ago
Add permission 'persistent-storage' for StorageManager
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: shawnjohnjr, Assigned: shawnjohnjr)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: btpp-active,[storage-v1])
Attachments
(1 file, 2 obsolete files)
|
3.52 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Add permission 'persistent-storage'
|
||
Comment 1•8 years ago
|
||
I'm guessing you're planning on working on this soon, Shawn, so I'm marking as 'fixlater'. Feel free to correct that.
Whiteboard: btpp-fixlater
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → shuang
|
|
Assignee | |
Comment 2•8 years ago
|
||
Based on https://w3c.github.io/permissions/#persistent-storage. "persistent-storage" permission allows an origin to make its site storage unit contain a persistent box. "persistent-storage" is a boolean feature.
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: btpp-fixlater → btpp-active
|
||
Updated•7 years ago
|
Whiteboard: btpp-active → btpp-active,storage-v1
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8814885 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•7 years ago
|
||
|
|
Assignee | |
Comment 5•7 years ago
|
||
Comment on attachment 8815157 [details] [diff] [review] Bug 1270038 - Add permission 'persistent-storage' for StorageManager Hi baku, This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'. [1] https://w3c.github.io/permissions/#permission-registry [2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage
Attachment #8815157 -
Flags: review?(amarchesini)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8815157 -
Attachment is obsolete: true
Attachment #8815157 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 6•7 years ago
|
||
Oh. I just found test_permissions_api.html also copied to browser/components/originattributes/test/mochitest/test_permissions_api.html. I should also modify this test case.
|
|
Assignee | |
Comment 7•7 years ago
|
||
|
|
Assignee | |
Comment 8•7 years ago
|
||
Comment on attachment 8815169 [details] [diff] [review] Bug 1270038 - Add permission 'persistent-storage' for StorageManager Hi baku, This patch adds permission-registry PermissionName 'persistent-storage' to support querying permission 'persistent-storage'. [1] https://w3c.github.io/permissions/#permission-registry [2] https://storage.spec.whatwg.org/#dom-permissionname-persistent-storage I also tested this patch with patches on bug 1286717. It looks good.
Attachment #8815169 -
Flags: review?(amarchesini)
|
||
Updated•7 years ago
|
Attachment #8815169 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27f6a4bde78c6514da767f9850998016f6c81e9a
|
||
Comment 10•7 years ago
|
||
Pushed by shuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4c27ba3875 Add permission 'persistent-storage' for StorageManager, r=baku
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3e4c27ba3875
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•7 years ago
|
Keywords: dev-doc-needed
|
||
Updated•7 years ago
|
Whiteboard: btpp-active,storage-v1 → btpp-active,[storage-v1]
|
||
Comment 12•7 years ago
|
||
I've documented this. I've added details of the new permission name and updated browser support info on relevant pages: https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API https://developer.mozilla.org/en-US/docs/Web/API/Permissions https://developer.mozilla.org/en-US/docs/Web/API/Permissions/revoke https://developer.mozilla.org/en-US/docs/Web/API/Permissions/query I've also added a note to the Fx53 release notes: https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM Let me know if this looks OK - thanks!
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•