1270045 - Stop posting ctors data to graphs.m.o

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We're doing this from these builds:
Linux mozilla-esr38 build NightlyBuildFactory
Linux mozilla-esr45 build NightlyBuildFactory
Linux x86-64 mozilla-esr38 build NightlyBuildFactory
Linux x86-64 mozilla-esr45 build NightlyBuildFactory

TB Linux comm-aurora build NightlyBuildFactory
TB Linux comm-beta build NightlyBuildFactory
TB Linux comm-central build NightlyBuildFactory
TB Linux comm-esr38 build NightlyBuildFactory
TB Linux comm-esr45 build NightlyBuildFactory
TB Linux cypress build NightlyBuildFactory
TB Linux x86-64 comm-aurora build NightlyBuildFactory
TB Linux x86-64 comm-beta build NightlyBuildFactory
TB Linux x86-64 comm-central build NightlyBuildFactory
TB Linux x86-64 comm-esr38 build NightlyBuildFactory
TB Linux x86-64 comm-esr45 build NightlyBuildFactory
TB Linux x86-64 cypress build NightlyBuildFactory

The code in question is http://hg.mozilla.org/build/buildbotcustom/file/default/process/factory.py#l1410, so just unsetting graph_server will mean we still collect the data in the build log, just not submit to graph.m.o.

This will also fix bug 1262760.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Stop posting

FWIW, in mozharness we collect ctors info and it makes it to perfherder, eg https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=%5Bmozilla-central,45b561e2236d7631af037d960a78410227317660,1%5D

No point porting that to ESR38/45, and TB is stuck on buildbot. ctors are the least of their worries.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

:nthomas, I had thought this was resolved with the work I did here:
https://reviewboard.mozilla.org/r/36903/

I guess that doesn't apply to nightlies and esr.  We don't have a need to collect ctors from esr, so this seems reasonable from the firefox side.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Thanks for the pointer, now I know how mozharness got fixed. This patch just affects the builds still using a Buildbot factory (NightlyBuildFactory) - boo code divergence. They're not actually nightlies, I just didn't trim the factory name off each of those lines in the initial comment.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8748552 [details] [diff] [review]
[buildbot-configs] Stop posting

https://hg.mozilla.org/build/buildbot-configs/rev/befb16732497
https://hg.mozilla.org/build/buildbot-configs/rev/2eefce8cc6de

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Did some spot checks on ESR and the graph post are gone.