Closed Bug 1270045 Opened 8 years ago Closed 8 years ago

Stop posting ctors data to graphs.m.o

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(1 file)

We're doing this from these builds:
Linux mozilla-esr38 build NightlyBuildFactory
Linux mozilla-esr45 build NightlyBuildFactory
Linux x86-64 mozilla-esr38 build NightlyBuildFactory
Linux x86-64 mozilla-esr45 build NightlyBuildFactory

TB Linux comm-aurora build NightlyBuildFactory
TB Linux comm-beta build NightlyBuildFactory
TB Linux comm-central build NightlyBuildFactory
TB Linux comm-esr38 build NightlyBuildFactory
TB Linux comm-esr45 build NightlyBuildFactory
TB Linux cypress build NightlyBuildFactory
TB Linux x86-64 comm-aurora build NightlyBuildFactory
TB Linux x86-64 comm-beta build NightlyBuildFactory
TB Linux x86-64 comm-central build NightlyBuildFactory
TB Linux x86-64 comm-esr38 build NightlyBuildFactory
TB Linux x86-64 comm-esr45 build NightlyBuildFactory
TB Linux x86-64 cypress build NightlyBuildFactory

The code in question is http://hg.mozilla.org/build/buildbotcustom/file/default/process/factory.py#l1410, so just unsetting graph_server will mean we still collect the data in the build log, just not submit to graph.m.o.

This will also fix bug 1262760.
FWIW, in mozharness we collect ctors info and it makes it to perfherder, eg https://treeherder.mozilla.org/perf.html#/graphs?timerange=2592000&series=%5Bmozilla-central,45b561e2236d7631af037d960a78410227317660,1%5D

No point porting that to ESR38/45, and TB is stuck on buildbot. ctors are the least of their worries.
Attachment #8748552 - Flags: review?(bhearsum)
:nthomas, I had thought this was resolved with the work I did here:
https://reviewboard.mozilla.org/r/36903/

I guess that doesn't apply to nightlies and esr.  We don't have a need to collect ctors from esr, so this seems reasonable from the firefox side.
Thanks for the pointer, now I know how mozharness got fixed. This patch just affects the builds still using a Buildbot factory (NightlyBuildFactory) - boo code divergence. They're not actually nightlies, I just didn't trim the factory name off each of those lines in the initial comment.
Attachment #8748552 - Flags: review?(bhearsum) → review+
Did some spot checks on ESR and the graph post are gone.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: