1270071 - Missing icons for toggle buttons

Status: RESOLVED WORKSFORME

(DevTools :: JSON Viewer, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

JSON Viewer is loading icons for the toggle buttons (used to expand/collapse the JSON tree) using chrome:// protocol. This is wrong since chrome://devtools/content is not contentaccessible (I've been always a bit puzzled why this worked before)

The correct way seems to be using resource:// protocol instead.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1270071.patch

@jryans: what do you think?

- load toggle icons through resource:// protocol
- get theme class name(s) from theme definition

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@jryans: some CSS changes are yet needed, but I am curious if this approach looks good to you.

Honza

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8748601 [details] [diff] [review]
bug1270071.patch

Review of attachment 8748601 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like the right approach overall!

::: devtools/client/jsonview/converter-child.js
@@ +215,5 @@
>  
> +    // Get theme class name(s) from theme definition.
> +    let currentTheme = JsonViewUtils.getCurrentTheme();
> +    let themeDef = gDevTools.getThemeDefinition(currentTheme);
> +    let themeClassName = themeDef.classList.join(" ");

I would say let's add a new `getCurrentThemeDefinition` to gDevTools to help with this and remove `JsonViewUtils.getCurrentTheme`.