1270083 - HashChangeEvent members are not nullable

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Anne (:annevk)]

It seems this has been a longstanding issue with the standard that only ended up being copied by Firefox. See https://github.com/whatwg/html/issues/1178 for more context.

Comment 1

[Andrew Overholt [:overholt]]

How urgently do we need to fix this, Anne?

Comment 2

[Anne (:annevk)]

No rush, super trivial though.

Comment 3

[Ben Tian (inactive)]

Anne,

I'm confused. What should we do on gecko? The standard [1] says HashChangeEvent members are default to empty string and so does gecko implementation [2].

[1] https://html.spec.whatwg.org/multipage/browsers.html#the-hashchangeevent-interface
[2] http://mxr.mozilla.org/mozilla-central/source/dom/webidl/HashChangeEvent.webidl

Comment 4

[Anne (:annevk)]

Sorry for the vague description. "DOMString?" needs to become "DOMString" throughout (so four times). We could also change it to "USVString" but I'm not sure that's needed as part of this bug.

Comment 5

[Ben Tian (inactive)]

Ah I see. I was focusing on HashChangeEventInit mentioned in comment 0 link.

I'll work on this bug.

Comment 6

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Make HashChangeEvent members non-nullable, r=khuey

Comment 7

[Ben Tian (inactive)]

Comment on attachment 8749589 [details] [diff] [review]
[final] Patch 1: Make HashChangeEvent members non-nullable, r=khuey

Kyle,

Can you review my patch that makes HashChangeEvent members non-nullable per comment 0 and comment 4? The try result is in
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66aba1f24246

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91d119eb3e94

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/91d119eb3e94