1270087 - Passcode bullets are not visible in landscape view

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build: 4.0.0b7
iOS: 8.4

Steps to reproduce:
1. Launch Firefox
2. Access Settings
3. Turn Passcode on
4. Tap Change Passcode
5. Change device orientation to landscape

Actual results:
- The Passcode bullets are not fully displayed.

Expected Results:
- The Passcode bullets should be visible.

Comment 1

[Aaron Train [:aaronmt]]

Screenshot?

Comment 2

[Simon Basca [:SimonB]]

Attachment: Please see the attached screenshot for more information.

Comment 3

[Stephan Leroux [:sleroux]]

Any objections with locking this to portrait mode if I can? Don't see why we would need to support landscape for passcode input.

Comment 4

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #3)
> Any objections with locking this to portrait mode if I can? Don't see why we
> would need to support landscape for passcode input.

IIRC, we had already decided to lock this in portrait.

Comment 5

[Stephan Leroux [:sleroux]]

That's what I thought. So probably a regression then. I'll fix it to stay portrait.

Comment 6

[Tyler Lacroix [:tlacroix]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1798

Comment 7

[Stephan Leroux [:sleroux]]

Comment on attachment 8750954 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1798

Almost there - just a couple nits and an issue with the animation.

Comment 8

[Stephan Leroux [:sleroux]]

Instead of locking to portrait, :tlacroix found a better way to move the elements into view and auto-center if the keyboard is up which solves the original problem of not seeing the dots. Would you prefer to lock it or go with this approach?

Comment 9

[Stephan Leroux [:sleroux]]

Comment on attachment 8750954 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1798

Revised changes look good!

Comment 10

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #8)
> Instead of locking to portrait, :tlacroix found a better way to move the
> elements into view and auto-center if the keyboard is up which solves the
> original problem of not seeing the dots. Would you prefer to lock it or go
> with this approach?

LGTM!

Comment 11

[Stephan Leroux [:sleroux]]

master 4735cbbc1abe32003f19ab4d22a0219438ac4611

Comment 12

[Simon Basca [:SimonB]]

Tested on master afdbc70
The password bullets are fully displayed.