1270139 - remove last use of domutils.colorToRGBA

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P1)

Description

[Tom Tromey :tromey]

The patch for bug 1266842 missed one use of domutils.colorToRGBA.

Comment 1

[Tom Tromey :tromey]

Attachment: MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r=pbro

Bug 1266842 missed a spot using colorToRGBA.  Changing this revealed
that the hsltorgb algorithm was a bit off; so this patch changes it to
be a js port of NS_HSL2RGB.

Review commit: https://reviewboard.mozilla.org/r/50493/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50493/

Comment 2

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d98b8da3091b42230ce6aaffa7c52c928619e81a

Comment 3

[Tom Tromey :tromey]

Retriggering in my previous try run didn't show the problem, so I've rebased to start a new one.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8748711 [details]
MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r=pbro

https://reviewboard.mozilla.org/r/50493/#review47701

Comment 5

[Tom Tromey :tromey]

Since bug 1265787, this was the last use of domutils in css-color.js.
So, I'm going to attach a small update that removes the import.

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8748711 [details]
MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50493/diff/1-2/

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e818d8cb31a9

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e818d8cb31a9