1270160 - Setting identity.fxaccounts.remote.webchannel.uri to empty string breaks firefox

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[u570621]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160502160818

Steps to reproduce:

1) Go to about:config
2) Set "identity.fxaccounts.remote.webchannel.uri" to an empty string instead of "https://accounts.firefox.com/"
3) Close firefox.
4) Open firefox.
5) Observe that e.g. about:customizing is now an empty window.


Actual results:

Stuff breaks.


Expected results:

Stuff should not break.

Comment 1

[[:philipp]]

the issue is easily reproducible & this is the regression range: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=feefdfa526a80bc51010582ca8eae5263735a657&tochange=eac6ac60b5e648bd0bb52a8a085f73491bf66faa

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1270160-gracefully-handle-no-webchannel-uri-pref.patch

EnsureFxAccountsWebChannel() failing causes the FxA browser UI to fail at initialize time causing bad things to happen. I decided that explicitly setting it to an empty string should make a little less noise than "real" failures.

Comment 3

[Shane Tomlinson [:stomlinson]]

Comment on attachment 8748908 [details] [diff] [review]
0001-Bug-1270160-gracefully-handle-no-webchannel-uri-pref.patch

Review of attachment 8748908 [details] [diff] [review]:
-----------------------------------------------------------------

On the surface, looks good. I am in the process of re-downloading m-c to apply the patch and test.

::: services/fxaccounts/FxAccountsWebChannel.jsm
@@ +450,5 @@
>    if (!singleton) {
> +    try {
> +      let contentUri = Services.urlFormatter.formatURLPref("identity.fxaccounts.remote.webchannel.uri");
> +      // Allow this being set to an empty string for people who want to
> +      // completely FxA webchannel support.

Should |completely| be |completely disable|?

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Thanks Shane.

(In reply to Shane Tomlinson [:stomlinson] from comment #3)
> > +      // Allow this being set to an empty string for people who want to
> > +      // completely FxA webchannel support.
> 
> Should |completely| be |completely disable|?

I'm actually thinking I should not bother to add a comment there at all - it should be obvious that no preference value means we simply can't use the channel - what do you think?

Comment 5

[Shane Tomlinson [:stomlinson]]

> 
> I'm actually thinking I should not bother to add a comment there at all - it
> should be obvious that no preference value means we simply can't use the
> channel - what do you think?


This seems reasonable to me. I'm wondering if a follow on path is worthwhile, were no Sync related functionality is available of the pref is cleared?

Comment 6

[Shane Tomlinson [:stomlinson]]

Comment on attachment 8748908 [details] [diff] [review]
0001-Bug-1270160-gracefully-handle-no-webchannel-uri-pref.patch

Review of attachment 8748908 [details] [diff] [review]:
-----------------------------------------------------------------

Tested locally, works as advertised, approach is sane.

::: services/fxaccounts/FxAccountsWebChannel.jsm
@@ +450,5 @@
>    if (!singleton) {
> +    try {
> +      let contentUri = Services.urlFormatter.formatURLPref("identity.fxaccounts.remote.webchannel.uri");
> +      // Allow this being set to an empty string for people who want to
> +      // completely FxA webchannel support.

Should |completely| be |completely disable|?

Comment 7

[Shane Tomlinson [:stomlinson]]

markh: do you mind checking this in to m-c or fx-team? I have no commit rights.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e34254bca3f4

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e34254bca3f4