1270247 - Crash in ParamTraits<mozilla::net::NetAddr>::Write instead of sending a malformed message

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Andrew McCreight [:mccr8]]

In bug 1259192, Kan-ru pointed out that we should crash while writing a NetAddr, rather than sending off a truncated message that will cause the receiver to crash. At least in the former case, we may be able to get crash information about what is going wrong.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Crash in ParamTraits<mozilla::net::NetAddr>::Write if the family is unknown.

I'm doing a try push just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6adef0c838df

Comment 2

[u408661]

Comment on attachment 8748851 [details] [diff] [review]
Crash in ParamTraits<mozilla::net::NetAddr>::Write if the family is unknown.

Review of attachment 8748851 [details] [diff] [review]:
-----------------------------------------------------------------

The socket family that no one expected (and is undocumented?), apparently... ugh.

Comment 3

[Dragana Damjanovic [:dragana]]

(In reply to Nicholas Hurley [:nwgh][:hurley] from comment #2)
> Comment on attachment 8748851 [details] [diff] [review]
> Crash in ParamTraits<mozilla::net::NetAddr>::Write if the family is unknown.
> 
> Review of attachment 8748851 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> The socket family that no one expected (and is undocumented?), apparently...
> ugh.

I would like to know what it is :)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9482cba39f3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9482cba39f3

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Add crash annotation for unknown socket family.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=64d214392179&selectedJob=20718885

Comment 7

[u408661]

Comment on attachment 8751778 [details] [diff] [review]
part 2 - Add crash annotation for unknown socket family.

Review of attachment 8751778 [details] [diff] [review]:
-----------------------------------------------------------------

I fully look forward to this being a socket family that isn't #define'd anywhere, on any system, ever :)

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32aaa53f9ddf

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/32aaa53f9ddf