remove pseudo class :-moz-dir after :dir is shipped

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bmo, Assigned: bmo)

Tracking

(Blocks 1 bug, {dev-doc-complete, site-compat})

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

3 years ago
Per bug 859301 comment 27, it's better to leave :-moz-dir() for a short transition period rather than removing it at exactly the same time as adding :dir.
Open this bug to track the removal status.
Assignee

Updated

3 years ago
Depends on: 859301
Assignee

Updated

3 years ago
Blocks: unprefix
Can we do some research to see how widely used :-moz-dir() is (and if sites using it include an unprefixed fallback) before removing it?

Comment 2

3 years ago
Adding Blink and WebKit bugs to "See Also" field
I don't really believe this is widely-used currently. And even if it is, given that neither WebKit/Blink nor IE/Edge support it, I don't think removing the unprefixed version would break websites badly.

I guess the best way to research this is to query the httparchive on the BigQuery. Hopefully they have CSS files included.
Assignee

Updated

3 years ago
Assignee: nobody → aschen
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Assignee

Comment 7

3 years ago
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=901949ce5bcfb9a737ff30dcb469a71d87fc1264

Unprefix version had been shipped on FF49, it's time to remove the support of prefix one from FF53.
We will also take care of any webcompat issues jump out due to this change, and make the call whether or not worth doing it.
Assignee

Updated

3 years ago
Attachment #8813207 - Flags: review?(adw)
Attachment #8813208 - Flags: review?(pbrosset)
Attachment #8813209 - Flags: review?(xidorn+moz)

Comment 8

3 years ago
mozreview-review
Comment on attachment 8813209 [details]
Bug 1270406 - Remove :-moz-dir support.

https://reviewboard.mozilla.org/r/94716/#review95146
Attachment #8813209 - Flags: review?(xidorn+moz) → review+

Comment 9

3 years ago
mozreview-review
Comment on attachment 8813208 [details]
Bug 1270406 - Unprefix pseudo-class dir in DevTool resources.

https://reviewboard.mozilla.org/r/94714/#review95202
Attachment #8813208 - Flags: review?(pbrosset) → review+

Comment 10

3 years ago
mozreview-review
Comment on attachment 8813207 [details]
Bug 1270406 - Unprefix pseudo-class dir in browser resources.

https://reviewboard.mozilla.org/r/94712/#review95404
Attachment #8813207 - Flags: review?(adw) → review+
Assignee

Comment 11

3 years ago
Thanks for your review.

Comment 12

3 years ago
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96be179dc002
Unprefix pseudo-class dir in browser resources. r=adw
https://hg.mozilla.org/integration/autoland/rev/71620574d3e5
Unprefix pseudo-class dir in DevTool resources. r=pbro
https://hg.mozilla.org/integration/autoland/rev/1ba616d48ed7
Remove :-moz-dir support. r=xidorn

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/96be179dc002
https://hg.mozilla.org/mozilla-central/rev/71620574d3e5
https://hg.mozilla.org/mozilla-central/rev/1ba616d48ed7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.