Closed Bug 1270535 Opened 4 years ago Closed 6 months ago

Add "undo" action in snackbar when bookmark is edited or removed

Categories

(Firefox for Android :: General, defect, P5)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox-esr60 --- wontfix
firefox-esr68 69+ verified
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- wontfix
firefox69 --- verified

People

(Reporter: antlam, Assigned: ateslovan)

References

(Blocks 2 open bugs)

Details

(Keywords: good-first-bug, Whiteboard: [fennec68.1])

Attachments

(1 file)

No description provided.
Summary: Add "undo" action in snackbar when bookmark is removed → Add "undo" action in snackbar when bookmark is edited or removed
Priority: -- → P2
Priority: P2 → P3
feature improvement tha may be considered in the future
tracking-fennec: --- → ?
Version: unspecified → Trunk
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
Severity: normal → enhancement
Hardware: All → ARM
Type: enhancement → defect
Assignee: nobody → andrei.teslovan
Keywords: checkin-needed
Keywords: checkin-needed
Keywords: checkin-needed

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48e84bb4bade
Add "undo" action when bookmark is edited or removed; r=petru

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Flags: qe-verify+

Andrei, please request uplift to Fennec 68 Beta so we can ship your fix in Fennec 68 ESR.

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Beta/Release Uplift Approval Request

  • User impact if declined: When a user is editing or removing a bookmark there is no way to undo the changes.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open Fennec
  1. Add a few bookmarks
  2. Go to bookmarks tab
  3. Edit the bookmark, change some info there and press save
  4. When the snack bar appears press undo - the changes you made should be undone now
  5. Long tap on another bookmark
  6. Select remove
  7. The bookmark should be now removed and a snack bar should appear. Press undo on the snack bar - the bookmark should reappear in the list.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change should not be risky - we just added the option to revert the changes made to a bookmark.
  • String changes made/needed: bookmark_edit_undo
Flags: needinfo?(andrei.teslovan)
Attachment #9067017 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

I'm wondering if it'd be acceptable to defer this to 68.1?

Flags: needinfo?(cpeterson)

Hi!
Verified as fixed on Nightly 69.0a1 (2019-06-11) with Nexus 6P (Android 8.1.0), Google Pixel (Android 9), Xiaomi Mi4i (Android 5.0.2). Thanks.

Flags: qe-verify+

[Tracking Requested - why for this release]:

I'm wondering if it'd be acceptable to defer this to 68.1?

Sure. How should we tag this bug for 68.1? There is no tracking flag for esr68 yet.

Flags: needinfo?(cpeterson) → needinfo?(jcristau)

I'll just switch the uplift flag and we'll set tracking when those flags are available.

Flags: needinfo?(jcristau)

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

see comment 7

Attachment #9067017 - Flags: approval-mozilla-beta? → approval-mozilla-esr68?

(In reply to Julien Cristau [:jcristau] from comment #11)

I'll just switch the uplift flag and we'll set tracking when those flags are available.

Requesting the firefox-esr68 tracking flag now that it is available.

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Gives users the ability to undo changes when editing or removing a bookmark. Approved for Fennec 68.1b1.

Attachment #9067017 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Actually, holding off on this for now until I can confirm that the l10n bumper is ready to go on ESR68.

Attachment #9067017 - Flags: approval-mozilla-esr68+ → approval-mozilla-esr68?

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Per discussion with Flod, we can uplift this now along with a manual graft of l10n-changesets.json from Beta. Approved for 68.1b2. This will also be in tomorrow's Nightly build if QA wants to get a jump start on verification.

Attachment #9067017 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+

Hi!
Verified as fixed on the latest version of Nightly 68.1a1 (2019-07-10) with OnePlus 5T (Android 9), Samsung Galaxy Tab S3 (Android 8.0; Tablet), Huawei Honor 8 (Android 7).
We will add the verify flag after we test this on Fennec ESR 68.1b2.

Hi!
Verified as fixed on Fennec ESR 68.1b2 with:

  • Google Pixel 3a XL (Android 9)
  • Sony Xperia Z5 (Android 7.0)
  • Samsung Galaxy S9 (Android 8.0.0)
  • Sony Xperia Z3 (Android 5.1.1)
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Whiteboard: [fennec68.1]
You need to log in before you can comment on or make changes to this bug.