1270535 - Add "undo" action in snackbar when bookmark is edited or removed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P5)

Comment 1

[Wesly Huang (EPM)]

feature improvement tha may be considered in the future

Comment 2

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 3

[Andrei Teslovan [:ateslovan]]

Attachment: Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48e84bb4bade
Add "undo" action when bookmark is edited or removed; r=petru

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/48e84bb4bade

Comment 6

[Chris Peterson [:cpeterson]]

Andrei, please request uplift to Fennec 68 Beta so we can ship your fix in Fennec 68 ESR.

Comment 7

[Andrei Teslovan [:ateslovan]]

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Beta/Release Uplift Approval Request

• User impact if declined: When a user is editing or removing a bookmark there is no way to undo the changes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open Fennec

2. Add a few bookmarks
3. Go to bookmarks tab
4. Edit the bookmark, change some info there and press save
5. When the snack bar appears press undo - the changes you made should be undone now
6. Long tap on another bookmark
7. Select remove
8. The bookmark should be now removed and a snack bar should appear. Press undo on the snack bar - the bookmark should reappear in the list.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change should not be risky - we just added the option to revert the changes made to a bookmark.
• String changes made/needed: bookmark_edit_undo

Comment 8

[Julien Cristau [:jcristau]]

I'm wondering if it'd be acceptable to defer this to 68.1?

Comment 9

[Eliza Balazs]

Hi!
Verified as fixed on Nightly 69.0a1 (2019-06-11) with Nexus 6P (Android 8.1.0), Google Pixel (Android 9), Xiaomi Mi4i (Android 5.0.2). Thanks.

Comment 10

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

I'm wondering if it'd be acceptable to defer this to 68.1?

Sure. How should we tag this bug for 68.1? There is no tracking flag for esr68 yet.

Comment 11

[Julien Cristau [:jcristau]]

I'll just switch the uplift flag and we'll set tracking when those flags are available.

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

see comment 7

Comment 13

[Chris Peterson [:cpeterson]]

(In reply to Julien Cristau [:jcristau] from comment #11)

I'll just switch the uplift flag and we'll set tracking when those flags are available.

Requesting the firefox-esr68 tracking flag now that it is available.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Gives users the ability to undo changes when editing or removing a bookmark. Approved for Fennec 68.1b1.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Actually, holding off on this for now until I can confirm that the l10n bumper is ready to go on ESR68.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9067017 [details]
Bug 1270535 - Add "undo" action when bookmark is edited or removed; r?Petru

Per discussion with Flod, we can uplift this now along with a manual graft of l10n-changesets.json from Beta. Approved for 68.1b2. This will also be in tomorrow's Nightly build if QA wants to get a jump start on verification.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/ce6e51c4a463

Comment 18

[Eliza Balazs]

Hi!
Verified as fixed on the latest version of Nightly 68.1a1 (2019-07-10) with OnePlus 5T (Android 9), Samsung Galaxy Tab S3 (Android 8.0; Tablet), Huawei Honor 8 (Android 7).
We will add the verify flag after we test this on Fennec ESR 68.1b2.

Comment 19

[Diana Rus]

Hi!
Verified as fixed on Fennec ESR 68.1b2 with:

• Google Pixel 3a XL (Android 9)
• Sony Xperia Z5 (Android 7.0)
• Samsung Galaxy S9 (Android 8.0.0)
• Sony Xperia Z3 (Android 5.1.1)