Closed
Bug 1270564
Opened 9 years ago
Closed 9 years ago
Resizing the Synced Tabs sidebar shifts its contents
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
Firefox 49
People
(Reporter: rfeeley, Assigned: eoger)
Details
Attachments
(2 files, 1 obsolete file)
|
5.03 MB,
image/gif
|
Details | |
|
1.66 KB,
patch
|
eoger
:
review+
|
Details | Diff | Splinter Review |
STR
Be syncing at least device with a long name (iOS default)
ER
Resizing the sidebar should affect its contents like in history and bookmarks sidebar (meaning, not at all)
AR
Device name shifts over and twisty is cropped
| Assignee | ||
Comment 1•9 years ago
|
||
This fix is OSX only since Windows seems to be doing something reasonable already (see : http://recordit.co/b5DRLc3R18), is that okay with you Ryan?
Flags: needinfo?(rfeeley)
Attachment #8749435 -
Flags: review?(markh)
Updated•9 years ago
|
Attachment #8749435 -
Flags: review?(markh) → review+
| Reporter | ||
Comment 2•9 years ago
|
||
Screencast much appreciated. It still looks like there is some twisty-stranges going on – shrinking is better than cropping, but unless the other sidebars do this, I'd like to avoid that too.
Flags: needinfo?(rfeeley) → needinfo?(edouard.oger)
| Assignee | ||
Comment 3•9 years ago
|
||
With this patch the problem is gone on all platforms.
Assignee: nobody → edouard.oger
Attachment #8749435 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Flags: needinfo?(edouard.oger)
Attachment #8750435 -
Flags: review?(markh)
| Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8750435 [details] [diff] [review]
bug-1270564.patch
Review of attachment 8750435 [details] [diff] [review]:
-----------------------------------------------------------------
Carrying r+ forward
Attachment #8750435 -
Flags: review?(markh) → review+
| Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•9 years ago
|
Flags: qe-verify+
Comment 7•9 years ago
|
||
I managed to reproduce this issue on Firefox 48.0b1 and on Windows 10x64.
The issue is no longer reproducible on Firefox 51.0a1 (2016-08-25), Firefox 50.0a2 (2016-08-25), or on Firefox 49.0b6.
The tests were performed under Windows 10x64, Ubuntu 14.04x86 and under Mac OS X 10.11.1.
I am marking this issue Verified Fixed.
Status: RESOLVED → VERIFIED
status-firefox50:
--- → verified
status-firefox51:
--- → verified
Flags: qe-verify+
OS: Mac OS X → All
Hardware: x86 → All
You need to log in
before you can comment on or make changes to this bug.
Description
•