1270575 - Media Encoder threads leak until shutdown in MediaRecorder

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

When you Stop() a MediaRecorder, the Media Encoder thread isn't shut down.  If a MediaRecorder is running *at* shutdown, it uses a shutdown observer to kill the thread and close things, but normal patterns leave them lying around.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Shut down Media Encoder thread on Stop()

MozReview-Commit-ID: Flf5JGyWHkF

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Shut down Media Encoder thread on Stop()

Stop() is too early to shut down the read thread, apparently, though perhaps we could with a larger rework.  This seems simple and upliftable if we want.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=52482f7d221b

(and  https://treeherder.mozilla.org/#/jobs?repo=try&revision=65ce4eac1b3b with bug 988464's patch, which may show assertions for DOM Worker not shutting down in time).

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/350def59bcf7

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Note this really is a leak; multiple threads will leak if you use it multiple times.  They do get cleaned up by nsThreadManager which is why it was never flagged as a leak.

Presumably would affect pretty much every release.

Wontfix for esr45 as this is just a leak.  Same rationale for 47.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/350def59bcf7