Closed Bug 1270596 Opened 4 years ago Closed 4 years ago

Upgrade to ESLint 2.9.0 to handle ignore exceptions

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(2 files)

The .eslintignore file allows you to specific ignore exceptions (so files that _will_ be linted) using the "!/path/to/file" syntax, which we are using in various cases.

At the moment, ESLint 2.8.0 allows an older version of the "ignore" module which has bugs with this, and causes try linting runs to skip this files when instead they should be linted.

ESLint 2.9.0 includes a fix[1] for this.

[1]: https://github.com/eslint/eslint/issues/5979
Comment on attachment 8749340 [details]
MozReview Request: Bug 1270596 - Fix devtools after ESLint 2.9.0 upgrade. r=tromey

https://reviewboard.mozilla.org/r/50881/#review47573

Thank you.  This is fine.
Attachment #8749340 - Flags: review?(ttromey) → review+
Comment on attachment 8749339 [details]
MozReview Request: Bug 1270596 - Upgrade to ESLint 2.9.0. r=ahal

https://reviewboard.mozilla.org/r/50879/#review47745
Attachment #8749339 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/a745ab1bf3bf
https://hg.mozilla.org/mozilla-central/rev/9ef531371d45
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: General → Lint
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.