Closed
Bug 1270596
Opened 9 years ago
Closed 9 years ago
Upgrade to ESLint 2.9.0 to handle ignore exceptions
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(2 files)
The .eslintignore file allows you to specific ignore exceptions (so files that _will_ be linted) using the "!/path/to/file" syntax, which we are using in various cases.
At the moment, ESLint 2.8.0 allows an older version of the "ignore" module which has bugs with this, and causes try linting runs to skip this files when instead they should be linted.
ESLint 2.9.0 includes a fix[1] for this.
[1]: https://github.com/eslint/eslint/issues/5979
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50879/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50879/
Attachment #8749339 -
Flags: review?(ahalberstadt)
Attachment #8749340 -
Flags: review?(ttromey)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50881/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50881/
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8749340 [details]
MozReview Request: Bug 1270596 - Fix devtools after ESLint 2.9.0 upgrade. r=tromey
https://reviewboard.mozilla.org/r/50881/#review47573
Thank you. This is fine.
Attachment #8749340 -
Flags: review?(ttromey) → review+
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8749339 [details]
MozReview Request: Bug 1270596 - Upgrade to ESLint 2.9.0. r=ahal
https://reviewboard.mozilla.org/r/50879/#review47745
Attachment #8749339 -
Flags: review?(ahalberstadt) → review+
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a745ab1bf3bf
https://hg.mozilla.org/mozilla-central/rev/9ef531371d45
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
|
|
Assignee | |
Updated•9 years ago
|
Component: General → Lint
|
||
Updated•7 years ago
|
Product: Testing → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•