1270596 - Upgrade to ESLint 2.9.0 to handle ignore exceptions

Status: RESOLVED FIXED

(Firefox Build System :: Lint and Formatting, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The .eslintignore file allows you to specific ignore exceptions (so files that _will_ be linted) using the "!/path/to/file" syntax, which we are using in various cases.

At the moment, ESLint 2.8.0 allows an older version of the "ignore" module which has bugs with this, and causes try linting runs to skip this files when instead they should be linted.

ESLint 2.9.0 includes a fix[1] for this.

[1]: https://github.com/eslint/eslint/issues/5979

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1270596 - Upgrade to ESLint 2.9.0. r=ahal

Review commit: https://reviewboard.mozilla.org/r/50879/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50879/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1270596 - Fix devtools after ESLint 2.9.0 upgrade. r=tromey

Review commit: https://reviewboard.mozilla.org/r/50881/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50881/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d9773d0ee13

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8749340 [details]
MozReview Request: Bug 1270596 - Fix devtools after ESLint 2.9.0 upgrade. r=tromey

https://reviewboard.mozilla.org/r/50881/#review47573

Thank you.  This is fine.

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8749339 [details]
MozReview Request: Bug 1270596 - Upgrade to ESLint 2.9.0. r=ahal

https://reviewboard.mozilla.org/r/50879/#review47745

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a745ab1bf3bf
https://hg.mozilla.org/integration/fx-team/rev/9ef531371d45

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a745ab1bf3bf
https://hg.mozilla.org/mozilla-central/rev/9ef531371d45