1270622 - Land version 1.3.2 of the Loop system add-on in mozilla-central

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Changelog: https://github.com/mozilla/loop/blob/release/CHANGELOG.md

Comment 1

[Mark Banner (:standard8)]

Attachment: Land version 1.3.2 of the Loop system add-on in mozilla-central, rs=standard8 for already reviewed code.

Comment 2

[Mark Banner (:standard8)]

Changes:

- Bug 1270526 - Stop showing copy panel after 3 times instead of 5
- Bug 1257266 - Change NPS survey link to dynamically add firefox hello version number to survey link.
- Bug 1270123 - Some routers can cause "Copy Panel" to be turned on if internet is offline.
- Bug 1267960 - Hello copy popup notification is displayed upon copying the URL bar even if the user is already in a Hello call or shown enough times.
- Localisation updates.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5fe67c44f537

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5fe67c44f537

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8749379 [details] [diff] [review]
Land version 1.3.2 of the Loop system add-on in mozilla-central, rs=standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello - 1.3 releases.
[User impact if declined]: Minor improvements to how the prototype copy panel works ready for limited enabling of the feature once released. Also changes the feedback survey url so that we can identify the different add-on versions and better track responses.
[Describe test coverage new/current, TreeHerder]: Landed in m-c. Has unit tests.
[Risks and why]: Low, small localised changes
[String/UUID change made/needed]: None

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8749379 [details] [diff] [review]
Land version 1.3.2 of the Loop system add-on in mozilla-central, rs=standard8 for already reviewed code.

Let's uplift to aurora as planned.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/967d8df94b1b

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8749379 [details] [diff] [review]
Land version 1.3.2 of the Loop system add-on in mozilla-central, rs=standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.3.2
[User impact if declined]: Firefox 47 users won't have the same version as Firefox 46.
[Describe test coverage new/current, TreeHerder]: Landed in central & aurora. Shipped via go faster to beta 47 and now release 46
[Risks and why]: Landing shipped code.
[String/UUID change made/needed]: None

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8749379 [details] [diff] [review]
Land version 1.3.2 of the Loop system add-on in mozilla-central, rs=standard8 for already reviewed code.

Makes sense, Beta47+

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/70fa82df113b