Rename mExceptionHasBeenRisen to mExceptionWasRaised

RESOLVED FIXED in Firefox 49

Status

()

Core
DOM: Events
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
risen is the past participle of rise; raised is the past participle of
raise, which is what is done to exceptions.

See:
https://en.wiktionary.org/wiki/rise#Verb
https://en.wiktionary.org/wiki/raise#Verb (definition 2, though not sure
  if the use for exceptions is from 2.3 or 2.5)

(I wonder if mExceptionRaised would be simpler, though.)

MozReview-Commit-ID: 8Ynup8aDcLT
(Assignee)

Comment 1

2 years ago
Created attachment 8749418 [details] [diff] [review]
Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised
Attachment #8749418 - Flags: review?(bugs)
Whiteboard: btpp-active

Comment 3

2 years ago
Comment on attachment 8749418 [details] [diff] [review]
Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised

Hmm, shouldn't it then be
mExceptionWasRaised.
But you're the native English speaker, rs+
Attachment #8749418 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

2 years ago
Yes, mExceptionWasRaised is probably better.  (simple past rather than (present) perfect.)  I'll do that.
(Assignee)

Updated

2 years ago
Summary: Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised → Rename mExceptionHasBeenRisen to mExceptionWasRaised

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/730147bfebe3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.