1270649 - Rename mExceptionHasBeenRisen to mExceptionWasRaised

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

risen is the past participle of rise; raised is the past participle of
raise, which is what is done to exceptions.

See:
https://en.wiktionary.org/wiki/rise#Verb
https://en.wiktionary.org/wiki/raise#Verb (definition 2, though not sure
  if the use for exceptions is from 2.3 or 2.5)

(I wonder if mExceptionRaised would be simpler, though.)

MozReview-Commit-ID: 8Ynup8aDcLT

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(This was introduced in https://hg.mozilla.org/mozilla-central/rev/fd53318c79ce .)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8749418 [details] [diff] [review]
Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised

Hmm, shouldn't it then be
mExceptionWasRaised.
But you're the native English speaker, rs+

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Yes, mExceptionWasRaised is probably better.  (simple past rather than (present) perfect.)  I'll do that.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/730147bfebe3d2c7d3fe1d0848189a8cb0cc8927
Bug 1270649 - Rename mExceptionHasBeenRisen to mExceptionWasRaised.  r=smaug

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/730147bfebe3