risen is the past participle of rise; raised is the past participle of raise, which is what is done to exceptions. See: https://en.wiktionary.org/wiki/rise#Verb https://en.wiktionary.org/wiki/raise#Verb (definition 2, though not sure if the use for exceptions is from 2.3 or 2.5) (I wonder if mExceptionRaised would be simpler, though.) MozReview-Commit-ID: 8Ynup8aDcLT
Created attachment 8749418 [details] [diff] [review] Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised
Attachment #8749418 - Flags: review?(bugs)
(This was introduced in https://hg.mozilla.org/mozilla-central/rev/fd53318c79ce .)
Comment on attachment 8749418 [details] [diff] [review] Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised Hmm, shouldn't it then be mExceptionWasRaised. But you're the native English speaker, rs+
Attachment #8749418 - Flags: review?(bugs) → review+
Yes, mExceptionWasRaised is probably better. (simple past rather than (present) perfect.) I'll do that.
Summary: Rename mExceptionHasBeenRisen to mExceptionHasBeenRaised → Rename mExceptionHasBeenRisen to mExceptionWasRaised
https://hg.mozilla.org/integration/mozilla-inbound/rev/730147bfebe3d2c7d3fe1d0848189a8cb0cc8927 Bug 1270649 - Rename mExceptionHasBeenRisen to mExceptionWasRaised. r=smaug
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.