Closed Bug 1270672 Opened 3 years ago Closed 3 years ago

Re-enable the webgl conformance tests on e10s

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
e10s ? ---
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch re-enable the tests on e10s (obsolete) — Splinter Review
Looks like they got disabled for some reason when the 1.0.3 update landed. Try confirms that they're still green, so let's get them turned back on before that has a chance to change.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8de0bbd59a1a3ca6267fe3e108a4e4e0a98702a4&exclusion_profile=false

FWIW, M-e10s(gl) on Ash has already caught crashes and leaks that weren't being seen elsewhere, so there is value to running these tests under e10s mode as well as non-e10s.
Attachment #8749463 - Flags: review?(jgilbert)
Looks like test_conformance__textures__texture-size-limit.html needs to be explicitly skipped on ASAN as well due to frequently timing out (given the pre-existing fail-if annotation for Linux, I guess it's expected for that test to be flaky).
This makes ASAN a lot happier. While I was at it, I cleaned up a couple other annotations to be a bit more specific. Confirmed green on Try (the infra failures were because I had to tweak the buildbot max runtime for the e10s jobs and some of the slaves started running tests before picking up the newer value).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2434c5809ea227a0afb89b4edfe426f3d2bbb64&exclusion_profile=false&group_state=expanded
Attachment #8749463 - Attachment is obsolete: true
Attachment #8749463 - Flags: review?(jgilbert)
Attachment #8749790 - Flags: review?(jgilbert)
Attachment #8749790 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/1b4b8969b3f6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.