127069 - Default process heap is 1MB

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Suresh Duddi (gone)]

We waste about 800k of this 1MB default process heap. Garrett thinks we can
shrink this by using EDITBIN.EXE to resize this.

Ideal size would be 256K

Comment 1

[Garrett Arch Blythe]

Attachment: Patch to control default heap size.

Reclaim .75 MB of unutilized VM.

Comment 2

[Garrett Arch Blythe]

request for r= sr=

Comment 3

[Cathleen]

brendan, can you sr=? dp r=?

Comment 4

[Suresh Duddi (gone)]

Comment on attachment 70826 [details] [diff] [review]
Patch to control default heap size.

r=dp

Would be great if you can do the same to winEmbed.

Comment 5

[Garrett Arch Blythe]

Attachment: Patch to control default heap size.

Do the same magic for winEmbed per DP's request.

Comment 6

[Garrett Arch Blythe]

As a note to others so I can explain what is going on.

Each Win32 process has at least 1 heap associated with it.
This is the process heap, returned by GetProcessHeap().
If you were a "win32 SDK only" type programmer, this is likely the heap you 
would heavily utilize.

As it turns out, the heap we use mainly in mozilla is the MSVCRT heap, which is 
created independently by a HeapCreate() call in their CRT source.

We only appear to utilize less than 256k of the GetProcessHeap(), and most the 
action happens inside the CRT heap.

The heaps can be enumerated and walked on Win32 (err... NT), which is how we 
came about this knowledge (see the heap api for the kernel).  We had 9 heaps 
last time DP took a look.

Comment 7

[Garrett Arch Blythe]

Comment on attachment 70832 [details] [diff] [review]
Patch to control default heap size.

brendan said "sr=brendan"

Cathleen wants bake time for this.
Going to request driver approval.

Comment 8

[Mike Shaver (:shaver emeritus)]

Comment on attachment 70832 [details] [diff] [review]
Patch to control default heap size.

Sweet. a=shaver for 0.9.9.

Comment 9

[Garrett Arch Blythe]

Checking in embedding/tests/winEmbed/makefile.win;
/cvsroot/mozilla/embedding/tests/winEmbed/makefile.win,v  <--  makefile.win
new revision: 1.19; previous revision: 1.18
done
Checking in xpfe/bootstrap/makefile.win;
/cvsroot/mozilla/xpfe/bootstrap/makefile.win,v  <--  makefile.win
new revision: 1.59; previous revision: 1.58
done

Comment 10

[Stephen Walker]

Garrett, can you make a version of this patch for the gmake windows build? That 
build uses Makefile.in's instead of makefile.win's.

Comment 11

[Daniel Bratell]

Reopening so that we don't forget to fix it in the new build system (for win32) too.

Btw, which were the 7 other heaps beside the standard process heap and the C
library heap?

Comment 12

[Judson Valeski]

mfcEmbed should get this too (winEmbed is pretty much bitrotted and not used).

Comment 13

[Garrett Arch Blythe]

Attachment: Another patch to control default heap size.

Control heap size for mfcEmbed as well.
Address gmake Makefile.in files as well.

Request for r= sr= a= in order to call this one done.

Comment 14

[Garrett Arch Blythe]

As for the 7 other heaps:  Uknown origin.

Any piece of code we load, possibly even system DLLs, could create their own 
heap.

Those other heaps were all very small, 64k or 32k in VM size.

dp has the tools to produce their numbers, this is just off the top of my head.

Comment 15

[Cathleen]

dp, can you r=?  shaver, can you sr=?

Comment 16

[Stephen Walker]

anyone going to r=/sr= garrett's latest patch?

Comment 17

[Suresh Duddi (gone)]

Comment on attachment 70951 [details] [diff] [review]
Another patch to control default heap size.

r=dp

Comment 18

[Cathleen]

nsbeta1+

Comment 19

[Scott Collins]

Comment on attachment 70951 [details] [diff] [review]
Another patch to control default heap size.

sr=scc

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 70951 [details] [diff] [review]
Another patch to control default heap size.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 21

[Garrett Arch Blythe]

checked in.