1270746 - Remove hasInstance class hooks.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

evilpie asked about the DOM.  As I understand it, we'd just need to replace the current hasInstance class hooks on the DOM classes with JSNatives implementing the same logic that are defined as a property on the relevant constructor objects, right?

Comment 2

[Jason Orendorff [:jorendorff]]

yup

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1270746 part 1 - Remove hasInstance hook from CType objects. r?iain!

We can instead rely on the default behavior for instanceof in JS::OrdinaryHasInstance.

This works because these objects are callable (since the JSClass has a call-hook) and
they have a .prototype property that returns the value in the proto slot.

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1270746 part 2 - Add AutoSetResolvingWrapper helper RAII class. r?mccr8!

Depends on D141342

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1270746 part 3 - Replace hasInstance JSClass hook on wrapped natives with a Symbol.hasInstance native. r?mccr8!

Resolve a Symbol.hasInstance native function that works like the class hook.

Depends on D141343

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1270746 part 4 - Inline Proxy::hasInstance call instead of using a class hook. r?iain!

This can be changed more later on, but for now this ensures no change in behavior.

Depends on D141344

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1270746 part 5 - Remove hasInstance class hook. r?iain!

Code should use Symbol.hasInstance to customize instanceof behavior.

Depends on D141345

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/910c5efb495b
part 1 - Remove hasInstance hook from CType objects. r=iain
https://hg.mozilla.org/integration/autoland/rev/261afd35a438
part 2 - Add AutoSetResolvingWrapper helper RAII class. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/18c2025ccfab
part 3 - Replace hasInstance JSClass hook on wrapped natives with a Symbol.hasInstance native. r=peterv
https://hg.mozilla.org/integration/autoland/rev/31122b75a592
part 4 - Inline Proxy::hasInstance call instead of using a class hook. r=iain
https://hg.mozilla.org/integration/autoland/rev/cb11b00621a2
part 5 - Remove hasInstance class hook. r=iain

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/910c5efb495b
https://hg.mozilla.org/mozilla-central/rev/261afd35a438
https://hg.mozilla.org/mozilla-central/rev/18c2025ccfab
https://hg.mozilla.org/mozilla-central/rev/31122b75a592
https://hg.mozilla.org/mozilla-central/rev/cb11b00621a2