Closed Bug 1270968 Opened 8 years ago Closed 8 years ago

[EME] Clear GMP storage

Categories

(Core :: Audio/Video: Playback, defect, P1)

47 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox47 --- fixed
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

(Keywords: regression)

Attachments

(1 file)

In bug 1264497 we discovered we'd broken Netflix because we'd interfered with the node Id being stored by the Adobe GMP. And the fix in bug 1264497 would result in people who'd cleared GMP storage in order to work around the problem that bug 1264497 fixed, would end up with broken Netflix when the fix for bug 1264497 made it into their build.

This is part of a more general problem that occasionally we run into issues that can only be addressed by clearing GMP storage. So we need a way to cause GMP storage to be cleared. Ideally this should be pref controlled, so if need be we can hot fix it.
In bug 1264497 we discovered that Netflix was broken because we'd made a change
to not send the Adobe GMP the device bound nodeId, which it stored in GMP
storage. When the GMP was comparing the nodeId it had stored against what it was
passed (nothing) the comparison was failing. Users could have worked around this
problem by clearing their GMP storage, whereupon the Adobe GMP will have stored
"nothing" as its nodeId.

When bug 1264497 was fixed, users who'd cleared their storage will see Netflix
fail again, as their stored nodeId of "nothing" will again not match what we
pass in. So to fix Netflix for these users, we need to clear GMP storage.

This is another instance of a more general problem that we have occasionally
encountered, namely that sometimes GMP storage becomes incompatible, and we
need to clear it. Having a general mechanism that we can use to clear storage
remotely will be helpful, so this patch adds one, and triggers it to fire.

This mechanism is pref controlled, so that we can issue a hotfix if necessary
to clear GMP storage.

Review commit: https://reviewboard.mozilla.org/r/51181/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51181/
Attachment #8749835 - Flags: review?(gsquelart)
Comment on attachment 8749835 [details]
MozReview Request: Bug 1270968 - Add mechanism to clear GMP storage when its version changes. r?gerald

https://reviewboard.mozilla.org/r/51181/#review47889
Attachment #8749835 - Flags: review?(gsquelart) → review+
Comment on attachment 8749835 [details]
MozReview Request: Bug 1270968 - Add mechanism to clear GMP storage when its version changes. r?gerald

Approval Request Comment
[Feature/regressing bug #]: Widevine EME, supplementary fix for Bug 1264497.
[User impact if declined]: Users who worked around the failure in Bug 1264497 by clearing their browser's GMP storage will see the same error as in Bug 1264497 *again* when the fix in Bug 1264497 lands in beta unless we also have this patch.
[Describe test coverage new/current, TreeHerder]: We already have tests covering the function we're calling again here.
[Risks and why]: Low; we're just doing an existing operation in a new place.
[String/UUID change made/needed]: None.
Attachment #8749835 - Flags: approval-mozilla-beta?
Attachment #8749835 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d50ac88f8fee
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8749835 [details]
MozReview Request: Bug 1270968 - Add mechanism to clear GMP storage when its version changes. r?gerald

P1 recent regression, Aurora48+, Beta47+
Attachment #8749835 - Flags: approval-mozilla-beta?
Attachment #8749835 - Flags: approval-mozilla-beta+
Attachment #8749835 - Flags: approval-mozilla-aurora?
Attachment #8749835 - Flags: approval-mozilla-aurora+
(In reply to Chris Pearce (:cpearce) from comment #8)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e48696f59f03

(Beta try push for a group of uplift)
Version: unspecified → 47 Branch
You need to log in before you can comment on or make changes to this bug.