1271003 - Record whether we've used DXVA in the crash reports

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

I don't think we do this and it would be helpful.

Comment 1

[Benoit Girard (:BenWa)]

Here's how we report if we've used something to crash reporter:
http://mxr.mozilla.org/mozilla-central/search?string=ScopedGfxFeatureReporter&find=gfx&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozilla-central

Comment 2

[Ernest Yim [:ernest]]

Attachment: MozReview Request: Bug 1271003 - Record whether we've used DXVA in crash reports r=BenWa,jrmuizel

r=BenWa,jrmuizel

Review commit: https://reviewboard.mozilla.org/r/55510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55510/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8756977 [details]
MozReview Request: Bug 1271003 - Record whether we've used DXVA in crash reports r=BenWa,jrmuizel

https://reviewboard.mozilla.org/r/55510/#review52262

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8756977 [details]
MozReview Request: Bug 1271003 - Record whether we've used DXVA in crash reports r=BenWa,jrmuizel

https://reviewboard.mozilla.org/r/55510/#review52264

::: dom/media/platforms/wmf/DXVA2Manager.cpp:612
(Diff revision 1)
>  HRESULT
>  D3D11DXVA2Manager::Init(nsACString& aFailureReason)
>  {
>    HRESULT hr;
>  
> +  ScopedGfxFeatureReporter reporter("D3D11DXVA2");

nitpicking here but for some reason we're using DXVA2D3D11 in our string (telemetry, gfxCriticalNotes) so it might be easier to keep this consistent in both places.

Comment 5

[Ernest Yim [:ernest]]

Comment on attachment 8756977 [details]
MozReview Request: Bug 1271003 - Record whether we've used DXVA in crash reports r=BenWa,jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55510/diff/1-2/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20c1a4ec995f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20c1a4ec995f

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Could you backport this to aurora?

Comment 9

[Ernest Yim [:ernest]]

Comment on attachment 8756977 [details]
MozReview Request: Bug 1271003 - Record whether we've used DXVA in crash reports r=BenWa,jrmuizel

Approval Request Comment
[Feature/regressing bug #]: https://bugzilla.mozilla.org/show_bug.cgi?id=1271003
[User impact if declined]: No logging to see DXVA loaded (initialized)
[Describe test coverage new/current, TreeHerder]: Been in landed to inbound for ~4 days, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=20c1a4ec995f 
[Risks and why]: None

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8756977 [details]
MozReview Request: Bug 1271003 - Record whether we've used DXVA in crash reports r=BenWa,jrmuizel

more info, taking it

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5bc37d6d1fae