Closed
Bug 1271032
Opened 8 years ago
Closed 8 years ago
getPref does not aware Unicode string
Categories
(Core :: AutoConfig (Mission Control Desktop), defect)
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: emk, Assigned: mkaply)
References
Details
Attachments
(1 file)
3.43 KB,
patch
|
mkaply
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
ritu
:
approval-mozilla-esr45+
|
Details | Diff | Splinter Review |
I forgot to update the getPref implementation. [Tracking Requested - why for this release]: Fix inconsistency of bug 1267567 change.
Attachment #8749943 -
Flags: review?(mozilla)
Assignee | ||
Comment 1•8 years ago
|
||
Comment on attachment 8749943 [details] [diff] [review] Make getPref Unicode-aware r=mkaply assuming you've run the new test through try.
Attachment #8749943 -
Flags: review?(mozilla) → review+
Reporter | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=781707670930
Reporter | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c830ab6c217eec0ad735a6d71f249e1bb17b2c0a Bug 1271032 - Make getPref Unicode-aware. r=mkaply
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c830ab6c217e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8749943 [details] [diff] [review] Make getPref Unicode-aware [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This patch complements bug 1267567 and it need to land everywhere bug 1267567 has land. User impact if declined: Inconsistent AutoConfig API between ESR and Nightly. Fix Landed on Version: 49 (47 if aurora/beta uplift is approved) Risk to taking this patch (and alternatives if risky): Very low String or UUID changes made by this patch: None Approval Request Comment [Feature/regressing bug #]: 1137799 [User impact if declined]: See above. Not all enterprise use ESR releases. [Describe test coverage new/current, TreeHerder]: A basic unit test landed along with the patch. [Risks and why]: Very low [String/UUID change made/needed]: None
Attachment #8749943 -
Flags: approval-mozilla-esr45?
Attachment #8749943 -
Flags: approval-mozilla-beta?
Attachment #8749943 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•8 years ago
|
Attachment #8749943 -
Attachment description: patch → Make getPref Unicode-aware
Comment on attachment 8749943 [details] [diff] [review] Make getPref Unicode-aware Follow up to the fix made in bug 1267567, Aurora48+, Beta47+, ESR45+
Attachment #8749943 -
Flags: approval-mozilla-esr45?
Attachment #8749943 -
Flags: approval-mozilla-esr45+
Attachment #8749943 -
Flags: approval-mozilla-beta?
Attachment #8749943 -
Flags: approval-mozilla-beta+
Attachment #8749943 -
Flags: approval-mozilla-aurora?
Attachment #8749943 -
Flags: approval-mozilla-aurora+
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox-esr45:
--- → affected
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/115883bbe33f
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/168613131e6a
You need to log in
before you can comment on or make changes to this bug.
Description
•