Closed Bug 1271032 Opened 9 years ago Closed 9 years ago

getPref does not aware Unicode string

Categories

(Core :: AutoConfig (Mission Control Desktop), defect)

Product:
Core
Component:
AutoConfig (Mission Control Desktop)
Version:
46 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox47 --- fixed
firefox48 --- fixed
firefox49 --- fixed
firefox-esr45 47+ fixed

People

(Reporter: emk, Assigned: mkaply)

References

Details

Attachments

(1 file)

Make getPref Unicode-aware
3.43 KB, patch
mkaply
: review+
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
ritu
: approval-mozilla-esr45+
Details | Diff | Splinter Review
I forgot to update the getPref implementation. [Tracking Requested - why for this release]: Fix inconsistency of bug 1267567 change.
Attachment #8749943 - Flags: review?(mozilla)
Comment on attachment 8749943 [details] [diff] [review] Make getPref Unicode-aware r=mkaply assuming you've run the new test through try.
Attachment #8749943 - Flags: review?(mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c830ab6c217e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8749943 [details] [diff] [review] Make getPref Unicode-aware [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This patch complements bug 1267567 and it need to land everywhere bug 1267567 has land. User impact if declined: Inconsistent AutoConfig API between ESR and Nightly. Fix Landed on Version: 49 (47 if aurora/beta uplift is approved) Risk to taking this patch (and alternatives if risky): Very low String or UUID changes made by this patch: None Approval Request Comment [Feature/regressing bug #]: 1137799 [User impact if declined]: See above. Not all enterprise use ESR releases. [Describe test coverage new/current, TreeHerder]: A basic unit test landed along with the patch. [Risks and why]: Very low [String/UUID change made/needed]: None
Attachment #8749943 - Flags: approval-mozilla-esr45?
Attachment #8749943 - Flags: approval-mozilla-beta?
Attachment #8749943 - Flags: approval-mozilla-aurora?
Attachment #8749943 - Attachment description: patch → Make getPref Unicode-aware
Comment on attachment 8749943 [details] [diff] [review] Make getPref Unicode-aware Follow up to the fix made in bug 1267567, Aurora48+, Beta47+, ESR45+
Attachment #8749943 - Flags: approval-mozilla-esr45?
Attachment #8749943 - Flags: approval-mozilla-esr45+
Attachment #8749943 - Flags: approval-mozilla-beta?
Attachment #8749943 - Flags: approval-mozilla-beta+
Attachment #8749943 - Flags: approval-mozilla-aurora?
Attachment #8749943 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: