getPref does not aware Unicode string

RESOLVED FIXED in Firefox 47

Status

()

Core
AutoConfig (Mission Control Desktop)
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emk, Assigned: mkaply)

Tracking

46 Branch
mozilla49
Points:
---

Firefox Tracking Flags

(firefox47 fixed, firefox48 fixed, firefox49 fixed, firefox-esr4547+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8749943 [details] [diff] [review]
Make getPref Unicode-aware

I forgot to update the getPref implementation.

[Tracking Requested - why for this release]:
Fix inconsistency of bug 1267567 change.
Attachment #8749943 - Flags: review?(mozilla)
(Assignee)

Comment 1

2 years ago
Comment on attachment 8749943 [details] [diff] [review]
Make getPref Unicode-aware

r=mkaply assuming you've run the new test through try.
Attachment #8749943 - Flags: review?(mozilla) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c830ab6c217e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
(Reporter)

Comment 5

2 years ago
Comment on attachment 8749943 [details] [diff] [review]
Make getPref Unicode-aware

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
This patch complements bug 1267567 and it need to land everywhere bug 1267567 has land.
User impact if declined: Inconsistent AutoConfig API between ESR and Nightly.
Fix Landed on Version: 49 (47 if aurora/beta uplift is approved)
Risk to taking this patch (and alternatives if risky): Very low
String or UUID changes made by this patch: None

Approval Request Comment
[Feature/regressing bug #]: 1137799
[User impact if declined]: See above. Not all enterprise use ESR releases.
[Describe test coverage new/current, TreeHerder]: A basic unit test landed along with the patch.
[Risks and why]: Very low
[String/UUID change made/needed]: None
Attachment #8749943 - Flags: approval-mozilla-esr45?
Attachment #8749943 - Flags: approval-mozilla-beta?
Attachment #8749943 - Flags: approval-mozilla-aurora?
(Reporter)

Updated

2 years ago
Attachment #8749943 - Attachment description: patch → Make getPref Unicode-aware

Comment 6

2 years ago
Comment on attachment 8749943 [details] [diff] [review]
Make getPref Unicode-aware

Follow up to the fix made in bug 1267567, Aurora48+, Beta47+, ESR45+
Attachment #8749943 - Flags: approval-mozilla-esr45?
Attachment #8749943 - Flags: approval-mozilla-esr45+
Attachment #8749943 - Flags: approval-mozilla-beta?
Attachment #8749943 - Flags: approval-mozilla-beta+
Attachment #8749943 - Flags: approval-mozilla-aurora?
Attachment #8749943 - Flags: approval-mozilla-aurora+

Updated

2 years ago
status-firefox47: --- → affected
status-firefox48: --- → affected
status-firefox-esr45: --- → affected
tracking-firefox-esr45: ? → 47+

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/115883bbe33f
status-firefox48: affected → fixed

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/168613131e6a
status-firefox47: affected → fixed
https://hg.mozilla.org/releases/mozilla-esr45/rev/f6414e3aa3fe
status-firefox-esr45: affected → fixed
You need to log in before you can comment on or make changes to this bug.