1271059 - New Tab button under Window Close button (does not happen with a fresh profile)

Status: RESOLVED WONTFIX

(Firefox :: Extension Compatibility, defect)

Description

[Andrew Davies]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

Steps to reproduce:

Windows 10
Open Firefox
Have maybe 600px wide (not required)
Open 15 -  20 tabs (so too many tabs to show at once)
Move mouse over "New Tab" button (the "+" symbol top right corner)

The standard Windows "App Close" button goes over the top of the "+" symbol.



Actual results:

You click the "+" (New Tab" button and Firefox closes.


Expected results:

A new tab should be created

Comment 1

[Andrew Davies]

Attachment: Screenshot. Mouse is on horizontal line of the +

The attached is a screenshot taken when the mouse cursor is precisely on the horizontal line of the + symbol. The main Window Close button is significantly overhanging the "New Tab" button.

Comment 2

[Loic]

Are you able to reproduce the issue with a fresh profile?
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

It could be an issue with one of your add-ons.

Comment 3

[Andrew Davies]

Attachment: Screenshot when using new profile

The issue does not occur with a clean / new profile. The "New Tab" button stays to the left of the Window Minimise button.

Comment 4

[Andrew Davies]

This issue is not present with a fresh profile.

Comment 5

[Andrew Davies]

Only some Windows are effected. I have multiple Firefox Windows, each with multiple Tabs.

If the menu ("File, Edit, View, History, Bookmarks, Tools, Help") is shown then my tabs run under the "minimise / maximise / close" buttons and there is no overlap with the "New Tab" button.

Comment 6

[Andrew Davies]

I clicked "View->Toolbars->Menu bar" to remove the tick, then resized my window. That fixed that Window. Since then showing the menu bar or not has made no difference. All other windows are now fixed except for one.

The problem remains in a window where I have no menu bar. I can try to turn on the menu bar, but it doesn't appear in that window. Toggling "Menu Bar" from that Window effects all other Windows (turns the menu bar on/off/on/off) but not this one.

What is special about this particular Window is I have a tab open that uses "GeoLocation" and "GetUserMedia" it asks for permission to access the Webcam and to Share location.

I have just tried all combinations (cancelling the permissions window, allowing, denying....) no matter what I do the "New Tab" button is underneath the "Window Close" button, and I cannot get the Menu Bar to show.

Switching to another tab in that Window that doesn't use "GeoLocation" or "GetUserMedia" doesn't fix the issue.

Closing the tab with "GeoLocation" & "GetUserMedia" doesn't fix the issue with that Window.

I close that Window and create a new Window. It is fine and shows the Menu Bar. I open 10 tabs.

I turn off the Menu Bar.
I open the webpage with "GeoLocation" & "GetUserMedia". I dismiss the dialogue asking for permission.
Still all fine.
I reload the page.
I deny permision.
Still all fine.
I reload the page.
I allow permission to both.
Still all fine.

Now I cannot replicate the issue. All my Windows are fine.

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I am unable to reproduce the issue you have described, I have tried Firefox 42, the latest release 46.0.1 and the latest Nightly. Are you by any chance using a different theme than the default one in the profile you have seen the issue, or do you have UI altering add-ons? If so, you could try re-enabling add-ons one by one until the one with the issue is enabled.

Comment 8

[Andrew Davies]

I have the problem back today.

It is Firefox 43.0.1

When I turn the "Menu Bar", there is no overlap, but I cannot turn the "Menu Bar" on in some Windows.

I don't see anything special about the Windows affected. They are not "popup" windows. They have all been opened either with (ctrl+n) or dragging a tab off outside the window.

Information that may be of use.
Firefox crashes typically 3-10 times a per day. I am a "heavy" user. Typical memory use is 3Gb - 9Gb. When Firefox crashes the Windows go grey, then die, I then restart Firefox bringing restoring all the tabs.

After a restart today I had 23 Windows. I'd guess 7-10 of them were effected by this.
Today I tried creating a New Window. Turning the Menu Bar on. Then dragging tabs into the new window, it didn't transfer the bug into the new window.

For a few months now when I go to "Tools"->"Add-ons" it defaults to "Get Addon-ons" which just says "Loading". I have left it for for over 18 hours and it still said "Loading".
"Extensions" shows just the cog icon and search box.
"Services" shows Java, Adobe Acrobat, Silverlight, Shockwave Flash.

I know I have an addon called "Tab Memory Usage" that shows how much RAM each tab uses. In the tab at the top it shows eg "4.3M - 1271059 - New Tab" for this tab. <Memory Usage> - <Meta Title>.

I would love to disable the addon, and see if the problem goes away, but can't. If you know how to delete / disable an "Addon" outside of Firefox (maybe some .ini file) or on about:config - great; I will happily try anything.

Comment 9

[Andrew Davies]

Attachment: 3 stats. Shows tab overlap / under window icons

Top image: Rightmost tab active on-top of Window Icons

Middle image: "New Tab" active - mouse is over the "X" of the "Amazon UK Deals" tab as if wanting to close it.

Bottom image: mouse is over the "+" (new tab icon) but the "Window close" button is on top.

I CANNOT turn on the "Menu Bar". I can toggle the "tick" and it effects all other windows but not this window.

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Does the issue go away if you switch to the default theme, by going to about:addons (or Tools->Add-ons) and selecting the "Appearance" tab from the left side menu?

Comment 11

[Loic]

Yes, please try with default settings in Firefox, because this issue is probably related to a broken theme.

Comment 12

[Andrew Davies]

Problem remains with default theme.

Comment 13

[Ciprian Muresan [:cmuresan], Ecosystem QA]

From the screenshot you posted in comment 9 I can see that you have a lot of add-ons installed.
Could you please try and start Firefox in safe-mode, by clicking the Menu button, click the question mark button near Customize and click "Restart with add-ons disabled" and report back if the issue still reproduces?

Comment 14

[Andrew Davies]

I have restarted in safe-mode as described by Ciprian.

In short problem remains, but toggling "Menu Bar" fixes it for while "Menu Bar" is ticked, however when "Menu Bar" is ticked the menu bar still doesn't show in the effected windows.

With uneffected windows, showing the menu bar results in the tabs moving down slightly and going underneath the minimise/maximise/close button without overlap - no issue.

With effected windows, I cannot get the the menu bar to actually show, which would result in the tabs dropping down. However, when in safe mode with "Menu Bar" ticked (unlike in standard mode) they always leave a gap on the right hand side so to not overlap with minimise/maximise/close.

Comment 15

[Ciprian Muresan [:cmuresan], Ecosystem QA]

As this issue is not reproducible with a clean profile, I believe the issue is caused by some other extensions that you have installed. As such this is not a browser issue. 

Could you please go to about:support and copy everything you see in Extensions and post it in the bug? With this I can try to install all the add-ons you have in the hopes of reproducing the issue.

Comment 16

[Andrew Davies]

about:plugins shows lots of sensible info.
about:buildconfig I have shown at the bottom.
about:support doesn't seem to show any information. Below is following a "Copy text to clipboard"



Application Basics
------------------

Name:
Version:
Build ID:
Update Channel:
User Agent:
Multiprocess Windows:
Safe Mode:

Crash Reports
-------------

Extensions
----------

Graphics
--------

Important Modified Preferences
------------------------------

Important Locked Preferences
----------------------------

JavaScript
----------

Incremental GC:

Accessibility
-------------

Activated:
Prevent Accessibility:

Library Versions
----------------

Experimental Features
---------------------





------------------------------------

about:buildconfig

Source

Built from https://hg.mozilla.org/releases/mozilla-release/rev/e8bb3550be0f344804a13cc7aa268b91a9154e93
Build platform
target
i686-pc-mingw32
Build tools
Compiler 	Version 	Compiler flags
cl 	1800 	-TC -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4244 -wd4267 -wd4819 -we4553
cl 	1800 	-TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR- -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1 -Oi -Oy
Configure arguments

--enable-crashreporter --enable-release --enable-update-channel=release --enable-update-packaging --enable-jemalloc --enable-require-all-d3dc-versions --with-google-api-keyfile=/c/builds/gapi.data --with-google-oauth-api-keyfile=/c/builds/google-oauth-api.key --with-mozilla-api-keyfile=/c/builds/mozilla-desktop-geoloc-api.key --enable-warnings-as-errors --enable-eme=adobe --enable-official-branding --enable-verify-mar

Comment 17

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Based on the last comment, there clearly is something wrong with your Firefox profile.
The next thing that I will suggest will save your bookmarks, history, tabs, passwords, add-ons, and preferences and it might make the issue go away.

As such I would suggest doing the following:
1. Create a new Firefox Sync account.
2. Synchronize your account with your default profile.
3. Disconnect your Firefox account from the default profile.
4. Create a new Firefox profile.
5. Synchronize your new Firefox profile with the Firefox account (which you created at Step 1).
6. Disconnect your Firefox account.

Please try this and come back and tell us if the issue is still reproducible or not.

Comment 18

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Marking this as Resolved: Incomplete due to the lack of response from the reporter.
If anyone can still reproduce it on latest versions, feel free to reopen the issue and provide more information.

Comment 19

[Andrew Davies]

Yes, it is still present with 43.0.1

Comment 20

[Loic]

43 is EOLed and not supported anymore. So please, update to 47 and test again.

Comment 21

[Andrew Davies]

I uninstalled Firefox 43.0.1 (Help->About Firefox was showing it as "Up to date")
I installed Firefox 47.0.1 (fresh download)
I kept my profile from: .....\AppData\Roaming\Mozilla\Firefox\Profiles

I am still experiencing both issues:
 1) Tabs overlapping the minimise/maximise/close buttons in some Windows
 2) "Menu Bar" toggle only turns on/off menu bar in Windows that don't have the overlap issue

Comment 22

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Please try following the steps from comment 17 on the latest Firefox release (47.0.1) and post your results.

Comment 23

[Andrew Davies]

"does not happen with a fresh profile" may not be accurate.

When I tried a fresh profile I hammered it for about 30 minutes and couldn't find a way to recreate it, but in terms of load / memory usage that would have nowhere near reached my normal use. Right now Firefox is using 9.2Gb of RAM (not concerned about that due to the number of tabs/windows open). The RAM used is stable (not continuing to increase without reason).

I don't see correlation between what tabs I have open in a Window and the issue being present. I can open a brand new Window. Open 12 Tabs all on https://google.lt and the issue is present sometimes, others not. I can kill Firefox, Restore Session and the issue can be fixed with the Window I was working in, but now it is present in other Windows. If a Window has the issue it remains regardless of opening/closing tabs. What what i've seen it appears to be something random when creating/restoring Windows. Today I have 49 Windows open, 8 are effected with this issue.

Comment 24

[Andrew Davies]

I've not tried Firefox Sync.
Is there a way I can get a clear profile and copy windows/tabs/passwords/addons over to it without using Firefox Sync? (I don't need bookmarks/history, but no way can I send Mozilla copies of client authentication details)

Comment 25

[Andrew Davies]

Right clicking by the menu bar shows a small popup menu:
 Move to Menu
 Remove from Toolbar
 Menu Bar
 Bookmarks Toolbar
 Customise

Where is the "Menu Bar" toggle setting stored?
(tabs move up when menu is hidden, with a margin on the right added)
I think the "Menu Bar" setting may be stored on a per "Window" basis, or in more than one place in Firefox config settings. Maybe the setting isn't the same in all places which is resulting in this issue.

Comment 26

[Ciprian Muresan [:cmuresan], Ecosystem QA]

If you don't want to use Firefox Sync you can do it manually:

1. Go to about:support and click "Show Folder" under Application Basics.
2. Copy the contents of the newly opened folder and put it somewhere safe.
3. Close Firefox.
4. Install Nightly. (https://nightly.mozilla.org)
5. Create a new profile and start Nightly.
6. Go to about:support and click "Show Folder".
7. Close Nightly.
8. After Nightly has closed, copy the contents of the folder from Step 2 into the folder from Step 5.
9. Open Nightly.

All of your history, bookmarks, saved passwords and such should be in the newly created profile. 

Please report back if the issue persists or not. 

Thanks

Comment 27

[Andrew Davies]

I have done each step in Comment 26.

I was on Windows 10 and installed Nightly:
https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/firefox-50.0a1.en-US.win64.installer.exe

The problem persists. Nightly and Firefox 42 have the same issue.

The "Menu Bar" shows in some Windows and not in others. Toggling "Menu Bar" on/off does nothing to the affected Windows.

The minimise button in the top right corner continue to overlap the rightmost tab, and the maximise/close buttons overlap the "scroll right" and "+" (new tab) symbol in the affected Windows.

Comment 28

[Andrew Davies]

Attachment: Profile copied to Nightly 50.0.a1 - issue remains

Comment 29

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Based on our discussion up until this point, I'm pretty sure there's an add-on, or several, that is causing this. See comment 8 and comment 16.

Comment 30

[Andrew Davies]

I'd guess (absolutely no proof) it is an addon called "Tab Memory Usage" / Firefox upgrade compatibility thing.

I went from Firefox 3.6.28 to 23.0 to 26.0 (GeoLocation not working) to 26.0.1 to 28.0 (GeoLocation not working) to 28.0.1 to Firefox 32.0 (GeoLocation not working) to 32.0.3 to 36.0.1 then briefly to 42.0 then 43.0.1 then 47.0.1. 
I installed "Tab Memory Usage" after upgrading to 32.0.3 and had to upgrade it when going to 36.0.1. 
I first noticed this issue late December 2015 while using 32.0.3.

Is it possible for me to copy my session (Windows and Tabs / open URLs) and passwords to a different profile (manually). I can then work for a few days without any addons installed to check that it is addon related.

This way I'll know that it's not some memory violation / multi-thread issue when Firefox starts up and restores my hundreds of tabs as fast as it can.

I will then either copy over addons from the existing profile to try and find the fault, or simply install them all from new; whichever you prefer me do.

Comment 31

[Jorge Villalobos [:jorgev] (he/him)]

Mass-closing old Extension Compatibility bugs that relate to legacy add-ons or NPAPI plug-ins. If you think this bug is still valid, please reopen or comment.

Sorry for the bug spam, and happy Friday!