1271135 - window[''] warns "Empty string passed to getElementById()."

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Oriol Brufau [:Oriol]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160508030214

Steps to reproduce:

Run this code:
    window['']

Open the console.


Actual results:

The console has this warning:
    Empty string passed to getElementById().


Expected results:

The console shouldn't have this warning.
 - The warning is confusing because the user didn't call getElementById()
 - The warning exposes an internal thing: named properties on window object use GetElementById.
 - That behavior seems to be against the HTML spec, which says that named access should only happen when the name is not the empty string.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: checkEmptyWindowName.patch

I don't know who should review this. I choose jst because he reviewed bug 799875.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a4aa107239e4

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4aa107239e4

Comment 4

[Oriol Brufau [:Oriol]]

Can somebody assign the bug to me? Why can't I change the assignee of a bug filed by me?

Comment 5

[Johnny Stenback (:jst)]

Done, and I also gave you permission to edit bugs. With great powers comes great responsibility :)