Closed Bug 1271147 Opened 4 years ago Closed 4 years ago

Merge RegExpCreate and regexp_construct self-hosting builtins.

Categories

(Core :: JavaScript: Standard Library, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Now those are almost identical, except acceptable arguments count, and should be merged into single function.
Previously:
  regexp_construct
    1 or 2 arguments
    args[0] should be a string
    args[1] should be a string if supplied
  RegExpCreate
    2 arguments
    args[1] should be a string or undefined

Changed to:
  RegExpCreate
    1 or 2 arguments
    args[1] should be a string or undefined if supplied


there is also regexp_construct_no_sticky, but it's a bit different, and anyway I'm about to change it again in bug 1263340 to receive raw int32 flags slot value.
Attachment #8750186 - Flags: review?(till)
Comment on attachment 8750186 [details] [diff] [review]
Merge RegExpCreate and regexp_construct self-hosting builtins.

Review of attachment 8750186 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8750186 - Flags: review?(till) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c57fdf4b8e07f197d7355ffd005cfefb75715700
Bug 1271147 - Merge RegExpCreate and regexp_construct self-hosting builtins. r=till
https://hg.mozilla.org/mozilla-central/rev/c57fdf4b8e07
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.