1271147 - Merge RegExpCreate and regexp_construct self-hosting builtins.

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Tooru Fujisawa [:arai]]

Now those are almost identical, except acceptable arguments count, and should be merged into single function.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Merge RegExpCreate and regexp_construct self-hosting builtins.

Previously:
  regexp_construct
    1 or 2 arguments
    args[0] should be a string
    args[1] should be a string if supplied
  RegExpCreate
    2 arguments
    args[1] should be a string or undefined

Changed to:
  RegExpCreate
    1 or 2 arguments
    args[1] should be a string or undefined if supplied


there is also regexp_construct_no_sticky, but it's a bit different, and anyway I'm about to change it again in bug 1263340 to receive raw int32 flags slot value.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8750186 [details] [diff] [review]
Merge RegExpCreate and regexp_construct self-hosting builtins.

Review of attachment 8750186 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c57fdf4b8e07f197d7355ffd005cfefb75715700
Bug 1271147 - Merge RegExpCreate and regexp_construct self-hosting builtins. r=till

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c57fdf4b8e07