127117 - nsBlockFrame and nsLineBox need better separation

Status: NEW

(Core :: Layout: Block and Inline, defect, P3)

Description

[John Keiser (jkeiser)]

nsBlockFrame is constantly reaching into nsLineBox's internals and treating it
like a struct, attempting to ensure data integrity on its own.  Data integrity
in a class should be the responsibility of that class.  The
nsBlockFrame::DoRemoveFrame() is a good example of this.  In bug 125124 we
encountered a place where nsBlockFrame did not ensure data integrity between the
list of children of a line and its child count, which ultimately caused a crash.
 This method should be entirely in nsLineBox.h.  (Probably it is best to make it
a method in nsLineList or a static method in nsLineBox.) 
nsBlockFrame::AddFrames() is another good candidate.

It might be a decent idea to split nsLineList and nsLineBox into their own
separate .h files to keep size down, too.

This is the result of suggestions by Alex (and our subsequent conversation) in
response to my fix to bug 125124.

Comment 1

[Christine Hoffman]

Changing QA contact

Comment 2

[Kevin McCluskey (gone)]

Bulk moving P1-P5 un-milestoned bugs to future. 

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

->Layout: Block&Inline