Closed Bug 1271191 Opened 7 years ago Closed 7 years ago

Support CSS #rgba and #rrggbbaa color syntax in the inspector

Categories

(DevTools :: Inspector, enhancement)

enhancement
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: pbro, Assigned: nchevobbe)

References

Details

(Keywords: DevAdvocacy)

Attachments

(1 file)

Bug 567283 brings #rgba and #rrggbbaa color syntax to CSS.
See the intent to ship thread: https://groups.google.com/forum/#!topic/mozilla.dev.platform/00Tq2s58GwA

We need to make sure devtools recognizes these new color values as colors (shows color swatches in the rule-view and computed-view), and is able to convert between these new formats and other formats (for instance, shift-clicking on a color swatch should cycle through the different formats).

In particular, https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/css-color.js is impacted I think.
Also a spot in inplace-editor, see _incHexColor
Inspector bug triage. Filter on CLIMBING SHOES.
Severity: normal → enhancement
The intent to ship email was sent rather late, and the new CSS syntax actually already landed in mozilla-central, and will be shipping with 49. It would be nice to have devtools ready at the same time.
Assignee: nobody → chevobbe.nicolas
Add support for both syntax in CssColor
Add support in value increment
Edit several tests to make sure we handle these syntaxes all across the inspector (display swatch,
color increment, unit switching, …).

Review commit: https://reviewboard.mozilla.org/r/52117/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52117/
Attachment #8751587 - Flags: review?(mratcliffe)
I pushed my patch to TRY (only one platform) to ensure it doesn't break something (and it seems good) : https://treeherder.mozilla.org/#/jobs?repo=try&revision=da19cc727137
Status: NEW → ASSIGNED
Attachment #8751587 - Flags: review?(mratcliffe) → review+
Comment on attachment 8751587 [details]
MozReview Request: Bug 1271191 - Add support CSS #rgba and #rrggbbaa color syntax in the inspector. r=miker

https://reviewboard.mozilla.org/r/52117/#review49968

Nice and even completely green on try... an easy r+.
Keywords: DevAdvocacy
TRY is over (https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e8df9b706bc&selectedJob=20956794). There's  lots of failure, but I checked and I don't see how any of them are related to my patch.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8751a7511341
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
No longer blocks: top-inspector-bugs
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.