1271237 - Assert mIsFlushing is false in WMFMediaDataDecoder::ProcessDrain()

Status: NEW

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per bug 1270350 comment 3 and bug 1270350 comment 5.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Jean-Yves Avenard [:jya] from bug 1270350 comment #5)
> no this is a scenario that is not possible to encounter.
> Flush() is only ever called once a drain has completed (and DrainComplete()
> has been called).

Can you point me at the code about this?

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1d7fb09f433&selectedJob=20560144

Assertion failure: !mIsFlushing, at c:/builds/moz2_slave/try-w32-d-00000000000000000000/build/src/dom/media/platforms/wmf/WMFMediaDataDecoder.cpp:191 

Looks like we can't assert !mIsFlushing yet.

Comment 3

[Jean-Yves Avenard [:jya]]

I'm more saying that it really doesn't matter if we're flushing right after draining..

All samples output after Flush() has been called will be discarded anyway.

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3