Closed Bug 1271256 Opened 8 years ago Closed 8 years ago

Fix always passing tests in test_throttling.py

Categories

(Tree Management :: Treeherder, defect, P2)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

[treeherder] mozilla:fix-throttling-tests > mozilla:master
47 bytes, text/x-github-pull-request
wlach
: review+
Details | Review 
Several of the expected-actual comparisons in test_throttling.py don't use `assert` so will always pass.
Attachment #8750274 - Attachment is obsolete: true
Attachment #8750275 - Flags: review?(wlachance)
Attachment #8750275 - Flags: review?(wlachance) → review+
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/70ab1b9ef613adab930140cfd8ac31c9a501408a
Bug 1271256 - Fix always passing tests in test_throttling.py

The lack of the `assert` statement meant they would have always passed.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: