Closed
Bug 1271256
Opened 9 years ago
Closed 9 years ago
Fix always passing tests in test_throttling.py
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
Several of the expected-actual comparisons in test_throttling.py don't use `assert` so will always pass.
| Comment hidden (obsolete) |
|
||
Comment 2•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Attachment #8750274 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8750275 -
Flags: review?(wlachance)
|
||
Updated•9 years ago
|
Attachment #8750275 -
Flags: review?(wlachance) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/70ab1b9ef613adab930140cfd8ac31c9a501408a
Bug 1271256 - Fix always passing tests in test_throttling.py
The lack of the `assert` statement meant they would have always passed.
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Component: Treeherder: Docs & Development → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•