1271262 - Re-enable Graphite text shaping by default for release-channel builds

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

In mozilla-45 and following trains, we temporarily preffed off graphite2 on the release channels due to the number of fuzz-bugs that were being found, some of which could have security implications.

Now that the graphite2 code seems much more robust and stable -- we're on release 1.3.8 on all trains, since bug 1262846, and fuzzing is no longer finding new issues on a daily or even weekly basis -- I think it's time to revert that change and let graphite once again be preffed on for all channels.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Enable graphite2 font shaping by default for all channels

Comment 2

[Jonathan Kew [:jfkthame]]

cc: Tyson -- would you agree that the graphite2 fuzz-fest has settled down, such that it's OK to do this?

Comment 3

[Tyson Smith [:tsmith]]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> cc: Tyson -- would you agree that the graphite2 fuzz-fest has settled down,
> such that it's OK to do this?

Yes I'm confident that we have found the majority of the issues. Other than a few instances of Undefined Behavior nothing has come up over the last month of fuzzing.

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfdee370664467f2eeff14c29e6156d231e50b3a
Bug 1271262 - Enable graphite2 font shaping by default for all channels. r=jet

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfdee3706644

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Graphite2 font shaping is enabled by default.
[Links (documentation, blog post, etc)]: http://graphite.sil.org/

Comment 7

[Marcia Knous [:marcia]]

49+ for release notes, added "Graphite2 font shaping is enabled by default"