Re-enable Graphite text shaping by default for release-channel builds

RESOLVED FIXED in Firefox 49

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed, relnote-firefox 49+)

Details

Attachments

(1 attachment)

In mozilla-45 and following trains, we temporarily preffed off graphite2 on the release channels due to the number of fuzz-bugs that were being found, some of which could have security implications.

Now that the graphite2 code seems much more robust and stable -- we're on release 1.3.8 on all trains, since bug 1262846, and fuzzing is no longer finding new issues on a daily or even weekly basis -- I think it's time to revert that change and let graphite once again be preffed on for all channels.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
cc: Tyson -- would you agree that the graphite2 fuzz-fest has settled down, such that it's OK to do this?
Flags: needinfo?(twsmith)
(In reply to Jonathan Kew (:jfkthame) from comment #2)
> cc: Tyson -- would you agree that the graphite2 fuzz-fest has settled down,
> such that it's OK to do this?

Yes I'm confident that we have found the majority of the issues. Other than a few instances of Undefined Behavior nothing has come up over the last month of fuzzing.
Flags: needinfo?(twsmith)
Attachment #8750280 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfdee370664467f2eeff14c29e6156d231e50b3a
Bug 1271262 - Enable graphite2 font shaping by default for all channels. r=jet
https://hg.mozilla.org/mozilla-central/rev/bfdee3706644
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Graphite2 font shaping is enabled by default.
[Links (documentation, blog post, etc)]: http://graphite.sil.org/
relnote-firefox: --- → ?
49+ for release notes, added "Graphite2 font shaping is enabled by default"
You need to log in before you can comment on or make changes to this bug.