Closed Bug 1271280 Opened 7 years ago Closed 7 years ago

Places shutdown blockers have wrong names and are not properly reporting state.

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox47 --- fixed
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

MozReview Request: Bug 1271280 - Places shutdown blockers have wrong names and are not properly reporting state. r=adw
58 bytes, text/x-review-board-request
adw
: review+
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
Details 
2 issues:
1. The 2 blockers have the same name, this is a copy/paste typo
2. we are not assigning to the outparam in GetState, so we don't report a state
Summary: Shutdown blockers have wrong names and are not properly reporting state. → Places shutdown blockers have wrong names and are not properly reporting state.
Comment on attachment 8750316 [details]
MozReview Request: Bug 1271280 - Places shutdown blockers have wrong names and are not properly reporting state. r=adw

https://reviewboard.mozilla.org/r/51355/#review48165
Attachment #8750316 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/553a9575ad40
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8750316 [details]
MozReview Request: Bug 1271280 - Places shutdown blockers have wrong names and are not properly reporting state. r=adw

Approval Request Comment
[Feature/regressing bug #]: Places async shutdown
[User impact if declined]: AsyncShutdown Timeout crash metadata is wrong, doesn't help us figuring bug 1258350
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: Low risk, just assigning to an outparam
[String/UUID change made/needed]: none
Attachment #8750316 - Flags: approval-mozilla-beta?
Attachment #8750316 - Flags: approval-mozilla-aurora?
Comment on attachment 8750316 [details]
MozReview Request: Bug 1271280 - Places shutdown blockers have wrong names and are not properly reporting state. r=adw

Improves crash diagnostics, Aurora48+, Beta47+
Attachment #8750316 - Flags: approval-mozilla-beta?
Attachment #8750316 - Flags: approval-mozilla-beta+
Attachment #8750316 - Flags: approval-mozilla-aurora?
Attachment #8750316 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.