1271296 - [Elevated Update] Cannot use app.update.url.override to simulate FF update

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Description]:
The scenario below is needed to cover several scenarios from the elevated update testing: consecutive updates need to be simulated.


1. Have 1 admin user and 1 standard user.
2. Install Nightly using the admin user. (from http://archive.mozilla.org/pub/firefox/nightly/2016/04/2016-04-19-10-56-54-oak/firefox-48.0a1.en-US.mac.dmg)
3. Switch to standard user, update firefox is available.
4. Restart the browser. 
5. Input the admin credentials: Elevated Update
6. Firefox is updated to the latest version.
7. Quit Nightly.
8. Open Library/Caches/Mozilla/ -> delete updates folder.
9. Repeat Step 8 for all available users (in the case Nightly was installed and updated.)
10. Relog to the standard user, checking the system integrity:
10.1 sudo ps ax | grep updater
10.2 sudo launchctl list | grep updater
10.3 sudo ls -al /Library/LaunchDaemons | grep updater
10.4 sudo ls -al /Library/PrivilegedHelperTools | grep updater
11. About:config set app.update.log -> true.
12. About:config - add the pref: app.update.url.override - string type
13. Add string for the above pref: app.update.url.override -> http://people.mozilla.org/~spohl/bug394984/oak/update.xml
14 . Check for updates.


[Actual Result]:
The Nightly states that it's up to date.

[Expected Result]:
The application url override should kick in and an update should be available at STR no. 14.

Comment 1

[Stephen A Pohl [:spohl]]

Please change the steps to the following and let me know if this fixes it:

1. Have 1 admin user and 1 standard user.
2. Install Nightly using the admin user. (from http://archive.mozilla.org/pub/firefox/nightly/2016/04/2016-04-19-10-56-54-oak/firefox-48.0a1.en-US.mac.dmg)
3. Switch to standard user.
4. About:config set app.update.log -> true.
5. About:config - add the pref: app.update.url.override - string type
6. Add string for the above pref: app.update.url.override -> http://people.mozilla.org/~spohl/bug394984/oak/update.xml
7. Check for updates.
8. Restart the browser to apply updates.
9. Input the admin credentials: Elevated Update
10. Firefox is updated to the version mentioned in http://people.mozilla.org/~spohl/bug394984/oak/update.xml.
11. About:config - remove the pref: app.update.url.override
12. Restart Nightly.
13. Check for updates.
14. Restart the browser to apply updates
15. Verify that no elevated update is launched.

Comment 2

[Adrian Florinescu [:aflorinescu]]

We changed the steps as instructed and still no luck. Managed to get an override update (out of 6-7) by chance and then figured it must be because the 49 update starts downloading in the background, therefore we set a predefined profile just to check for updates and not actually perform them and this way we got able to use the override now. 
We believe it is enough to be able to finish the remaining testcases which requested consecutive updates.

One thing we noticed is that the update history (about:support / Update History) is not being reliable. The update history on standard user and the update history on Admin user differ. What's more, even though I did two updates (override + normal) the history only shows an update. We'll get back on this as we manage to get more information on it.

Comment 3

[Stephen A Pohl [:spohl]]

(In reply to Adrian Florinescu [:AdrianSV] from comment #2)
> We changed the steps as instructed and still no luck. Managed to get an
> override update (out of 6-7) by chance and then figured it must be because
> the 49 update starts downloading in the background, therefore we set a
> predefined profile just to check for updates and not actually perform them
> and this way we got able to use the override now. 
> We believe it is enough to be able to finish the remaining testcases which
> requested consecutive updates.

Yes, setting the app.update.url.override pref in prefs.js before starting Firefox as standard user is the ideal way to test this. Thanks!

> One thing we noticed is that the update history (about:support / Update
> History) is not being reliable. The update history on standard user and the
> update history on Admin user differ. What's more, even though I did two
> updates (override + normal) the history only shows an update. We'll get back
> on this as we manage to get more information on it.

This may or may not be because we're updating nightlies, i.e. the version number will be the same but the build id differs. Before filing a bug that blocks elevated updates it would be great to compare this behavior to updates on the regular mozilla nightly branch.

Comment 4

[Adrian Florinescu [:aflorinescu]]

Setting resolution as WFM due to the fact that switching the profile autoupdate option to manual solves the issue.