1271477 - widget/gtk/WidgetStyleCache.cpp:191:29: error: 'PodArrayZero' was not declared in this scope (--disable-dbus)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Beich]

In file included from widget/gtk/Unified_cpp_widget_gtk0.cpp:29:
widget/gtk/WidgetStyleCache.cpp:191:3: error: use of undeclared identifier
      'PodArrayZero'; did you mean 'mozilla::PodArrayZero'?
  PodArrayZero(sStyleStorage);
  ^~~~~~~~~~~~
  mozilla::PodArrayZero
dist/include/mozilla/PodOperations.h:65:1: note: 'mozilla::PodArrayZero'
      declared here
PodArrayZero(T (&aT)[N])
^
In file included from widget/gtk/Unified_cpp_widget_gtk0.cpp:29:
widget/gtk/WidgetStyleCache.cpp:198:3: error: use of undeclared identifier
      'PodArrayZero'; did you mean 'mozilla::PodArrayZero'?
  PodArrayZero(sWidgetStorage);
  ^~~~~~~~~~~~
  mozilla::PodArrayZero
dist/include/mozilla/PodOperations.h:65:1: note: 'mozilla::PodArrayZero'
      declared here
PodArrayZero(T (&aT)[N])
^
2 errors generated.

Comment 1

[Jan Beich]

--disable-dbus: https://treeherder.mozilla.org/#/jobs?repo=try&revision=10b467471548
--disable-dbus + comment 0 fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f1193da2178

Comment 2

[Jan Beich]

In file included from widget/gtk/Unified_cpp_widget_gtk1.cpp:128:
In file included from widget/gtk/nsWidgetFactory.cpp:34:
widget/gtk/WakeLockListener.h:17:10: fatal error: 'mozilla/ipc/DBusConnectionRefPtr.h'
      file not found
#include "mozilla/ipc/DBusConnectionRefPtr.h"
         ^
1 error

Comment 3

[Jan Beich]

--disable-dbus (currently):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c47c0b407535

--disable-dbus + comment 0 fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5172c647e27

--disable-dbus + comment 0 + comment 2 fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbb412d955ab

--enable-dbus (default) comment 0 + comment 2 fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2873ac3b4224

Comment 4

[Jan Beich]

Attachment: comment 0 fix

Apologies for mixing two separate issues but they're a bit hard to untangle due to namespace pollution caused by unified build.

Comment 5

[Jan Beich]

Attachment: comment 2 fix

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8750562 [details] [diff] [review]
comment 0 fix

Thanks!

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Jan Beich from comment #5)
> Created attachment 8750563 [details] [diff] [review]
> comment 2 fix

Thanks for fixing this issue.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/639d6b288e9b
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac974fdf2755

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/639d6b288e9b
https://hg.mozilla.org/mozilla-central/rev/ac974fdf2755

Comment 10

[Jan Beich]

Comment on attachment 8750562 [details] [diff] [review]
comment 0 fix

Chasing https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=cb42beedc07e

Approval Request Comment
[Feature/regressing bug #]: bug 1234158 regression
[User impact if declined]: --disable-dbus build broken
[Describe test coverage new/current, TreeHerder]: m-c
[Risks and why]: Low, can only break build on Linux
[String/UUID change made/needed]: None

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8750562 [details] [diff] [review]
comment 0 fix

Fix the build with some options, tiny risk, taking it.

Comment 12

[Jan Beich]

Only comment 0 fix (the approved patch), comment 2 fix dependency (bug 1266054) wasn't backported/nominated for Aurora48 yet.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/94c2c4e54006
I'm setting status48 to 'fixed', but this will make it difficult for us to see if/when the comment2fix patch is ready to be uplifted. If/when you request uplift for it, please try to remember to set status48 back to 'affected' to make it easier to see this in our uplift queries. :)

Comment 14

[Carsten Book [:Tomcat]]

jan, so does comment 0 or comment 2 fix (or both need to be uplifted ?)

Comment 15

[Jan Beich]

Bug 1266054 wasn't backported to FF48, so there was no need to backport comment 2 fix as well.