Baseline JIT: 'illegal instruction' crash on aarch64 target

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sk.alvin.x, Assigned: sk.alvin.x)

Tracking

({64bit})

Trunk
mozilla50
Other
Linux
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Assignee

Description

3 years ago
Posted file gdb-baseline.txt
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36

Steps to reproduce:

a) modify code to enable baseline JIT on aarch64
b) js-engine standalone compile 
c) run jsshell with empty loop 


Actual results:

jsshell crashed 


Expected results:

script normally exit
Assignee

Updated

3 years ago
Keywords: 64bit
OS: Unspecified → Linux
Assignee

Updated

3 years ago
Hardware: Unspecified → Other
Summary: Baseline JIT on arm64 "illeagal instruction" → Baseline JIT: 'illeagal instruction' crash on aarch64 target
Version: 46 Branch → Trunk
Assignee

Comment 1

3 years ago
Assignee

Updated

3 years ago
Group: core-security
Group: core-security → javascript-core-security
Jan, could you figure out what to do with this? Does it need to be a sec bug, etc.? Thanks.
Flags: needinfo?(jdemooij)
I don't think this has to be s-s.
Group: javascript-core-security
Flags: needinfo?(jdemooij)
Attachment #8759535 - Flags: review?(sstangl)
Summary: Baseline JIT: 'illeagal instruction' crash on aarch64 target → Baseline JIT: 'illegal instruction' crash on aarch64 target
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #8759535 - Flags: review?(sstangl) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed
Assignee

Comment 5

3 years ago
Posted patch aarch64-icache-flush.patch (obsolete) — Splinter Review
Sorry for my carelessness.Here is a new patch.
Attachment #8759535 - Attachment is obsolete: true
Attachment #8768651 - Flags: review?(sstangl)
Attachment #8768651 - Flags: review?(sstangl) → review+
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db2b6f8c1a8

sk, can you please add commit information to your patches so they're easier for people to checkin? Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Assignee: nobody → sk.alvin.x
Flags: needinfo?(sk.alvin.x)
Assignee

Comment 7

3 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> Try push:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db2b6f8c1a8
> 
> sk, can you please add commit information to your patches so they're easier
> for people to checkin? Thanks!
> https://developer.mozilla.org/en-US/docs/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F

Create a new patch and request for review?
You don't need to re-request review, just uploading a new patch with the missing information included will suffice.
Assignee

Comment 9

3 years ago
Flags: needinfo?(sk.alvin.x)
Attachment #8768651 - Attachment is obsolete: true
Thanks :)
Keywords: checkin-needed

Comment 11

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2763206148aa
Add autoflush icache for aarch64 target. r=sstangl
Keywords: checkin-needed

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2763206148aa
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.