1271565 - Baseline JIT: 'illegal instruction' crash on aarch64 target

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[sk]

Attachment: gdb-baseline.txt

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36

Steps to reproduce:

a) modify code to enable baseline JIT on aarch64
b) js-engine standalone compile 
c) run jsshell with empty loop 


Actual results:

jsshell crashed 


Expected results:

script normally exit

Comment 1

[sk]

Attachment: AutoFlushCache-support-for-aarch64

Comment 2

[Andrew McCreight [:mccr8]]

Jan, could you figure out what to do with this? Does it need to be a sec bug, etc.? Thanks.

Comment 3

[Jan de Mooij [:jandem]]

I don't think this has to be s-s.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This doesn't compile.
https://treeherder.mozilla.org/logviewer.html#?job_id=23466407&repo=try#L923

Comment 5

[sk]

Attachment: aarch64-icache-flush.patch

Sorry for my carelessness.Here is a new patch.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db2b6f8c1a8

sk, can you please add commit information to your patches so they're easier for people to checkin? Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 7

[sk]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> Try push:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db2b6f8c1a8
> 
> sk, can you please add commit information to your patches so they're easier
> for people to checkin? Thanks!
> https://developer.mozilla.org/en-US/docs/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F

Create a new patch and request for review?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

You don't need to re-request review, just uploading a new patch with the missing information included will suffice.

Comment 9

[sk]

Attachment: aarch64-autoflush-icache.patch

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Thanks :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2763206148aa
Add autoflush icache for aarch64 target. r=sstangl

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2763206148aa