Closed Bug 1271577 Opened 5 years ago Closed 5 years ago
Toolbar Text Selection: Remove debug log
It seems like I landed FloatingToolbarTextSelection with a debug statement: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java#107-108 -- To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build To fix this bug, you need to remove this method call: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java#107-108 Then, you'll need to create a patch to upload - see https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
Hi, as it would be my first time working on a bug, I would like to go for this good first bug if possible, thank you.
Alright! See comment 0 about how to setup a build environment (A "front-end" build is sufficient for this bug). After uploading a patch we'll assign the bug to you. Let me know if you have any further questions.
Hi there, I'd like to get started on this. Do you have any advice on how to proceed?
Here is the patch, also I just finished to setup the build environment (after long hours because I just forgot to run the build with the artifact mode lol).
Hi, my previous patch was invalid.. as it's my very first time contributing to mozilla I made some mistakes uploading it. Here is a valid one, Thanks!
Attachment #8753512 - Attachment is obsolete: true
Hi, Can I have a feedback plz ?
Assignee: nobody → billel.nazir
Status: NEW → ASSIGNED
Comment on attachment 8754164 [details] [diff] [review] name.patch Review of attachment 8754164 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Thank you! :)
Attachment #8754164 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/a5739014f365c8d4fd155dda18018cf21476b346 Bug 1271577 - FloatingToolbarTextSelection: Remove Log.w() call. r=sebastian
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.