FloatingToolbarTextSelection: Remove debug log

RESOLVED FIXED in Firefox 49

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: Mohammad.Billel, Mentored)

Tracking

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
It seems like I landed FloatingToolbarTextSelection with a debug statement:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java#107-108

--

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

To fix this bug, you need to remove this method call:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java#107-108

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches


If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC
(Assignee)

Comment 1

2 years ago
Hi, as it would be my first time working on a bug, I would like to go for this good first bug if possible, thank you.
(Reporter)

Comment 2

2 years ago
Alright!

See comment 0 about how to setup a build environment (A "front-end" build is sufficient for this bug). After uploading a patch we'll assign the bug to you. Let me know if you have any further questions.

Comment 3

2 years ago
Hi there,

I'd like to get started on this. Do you have any advice on how to proceed?
(Assignee)

Comment 4

2 years ago
Created attachment 8753512 [details] [diff] [review]
Patch uploading

Here is the patch, also I just finished to setup the build environment (after long hours because I just forgot to run the build with the artifact mode lol).
(Assignee)

Updated

2 years ago
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 5

2 years ago
Created attachment 8754164 [details] [diff] [review]
name.patch

Hi, my previous patch was invalid.. as it's my very first time contributing to mozilla I made some mistakes uploading it.
Here is a valid one, 
Thanks!
Attachment #8753512 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 6

2 years ago
Hi,
Can I have a feedback plz ?
Flags: needinfo?(s.kaspari)
(Reporter)

Updated

2 years ago
Assignee: nobody → billel.nazir
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
(Reporter)

Comment 7

2 years ago
Comment on attachment 8754164 [details] [diff] [review]
name.patch

Review of attachment 8754164 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you! :)
Attachment #8754164 - Flags: review+
(Reporter)

Comment 8

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/a5739014f365c8d4fd155dda18018cf21476b346
Bug 1271577 - FloatingToolbarTextSelection: Remove Log.w() call. r=sebastian

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a5739014f365
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.