1271577 - FloatingToolbarTextSelection: Remove debug log

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

It seems like I landed FloatingToolbarTextSelection with a debug statement:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java#107-108

--

To start, set up a build environment - you can see the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

To fix this bug, you need to remove this method call:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/text/FloatingToolbarTextSelection.java#107-108

Then, you'll need to create a patch to upload - see
https://wiki.mozilla.org/Mobile/Fennec/Android#Creating_commits_and_submitting_patches


If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "sebastian" and you can find me and other helpful folks in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Comment 1

[Mohammad.Billel]

Hi, as it would be my first time working on a bug, I would like to go for this good first bug if possible, thank you.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Alright!

See comment 0 about how to setup a build environment (A "front-end" build is sufficient for this bug). After uploading a patch we'll assign the bug to you. Let me know if you have any further questions.

Comment 3

[ben94lim]

Hi there,

I'd like to get started on this. Do you have any advice on how to proceed?

Comment 4

[Mohammad.Billel]

Attachment: Patch uploading

Here is the patch, also I just finished to setup the build environment (after long hours because I just forgot to run the build with the artifact mode lol).

Comment 5

[Mohammad.Billel]

Attachment: name.patch

Hi, my previous patch was invalid.. as it's my very first time contributing to mozilla I made some mistakes uploading it.
Here is a valid one, 
Thanks!

Comment 6

[Mohammad.Billel]

Hi,
Can I have a feedback plz ?

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8754164 [details] [diff] [review]
name.patch

Review of attachment 8754164 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thank you! :)

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/a5739014f365c8d4fd155dda18018cf21476b346
Bug 1271577 - FloatingToolbarTextSelection: Remove Log.w() call. r=sebastian

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5739014f365