1271579 - Integrate GtkTextDirection/GtkStateFlags to ClaimStyleContext

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from Bug 1234158 comment 82

It implements GtkTextDirection/GtkStateFlags as a part of ClaimStyleContext

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

I wonder if we need to set the GTK_STATE_FLAG_NORMAL state in ReleaseStyleContext(), as we do for menus when we don't call style save/restore.

IMHO we don't need that because the GTK_STATE_FLAG_NORMAL state is automatically passed to ClaimStyleContext(). It may cause problems when the style for particular widget is get from both widget and ClaimStyleContext - but that's no our case.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8750713 [details] [diff] [review]
patch

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=706cb34bf802

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch for check-in

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3de4044b57f4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3de4044b57f4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3de4044b57f4