Closed Bug 1271581 Opened 4 years ago Closed 4 years ago

MDSM::SeekComplted() should use newCurrentTime, instead of GetMediaTime(), to decide the nextState.

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: kaku, Assigned: kaku)

References

Details

Attachments

(1 file)

Follow bug 1235301 comment 41.

MDSM::SeekCompleted() checks |GetMediaTime() == Duration()...| (https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#1994) to decide the nextState. However, it should instead use the newCurrentTime.
Sorry, it should be bug 1235301 comment 40.
Assignee: nobody → kaku
Blocks: 1235301
Summary: MDSM::SeekComplted() should newCurrentTime, instead of GetMediaTime(), to decide the nextState. → MDSM::SeekComplted() should use newCurrentTime, instead of GetMediaTime(), to decide the nextState.
Comment on attachment 8750715 [details]
MozReview Request: Bug 1271581 - use newCurrentTime, instead of GetMediaTime() to decide the nextState; r?jwwang

https://reviewboard.mozilla.org/r/51611/#review48415
Attachment #8750715 - Flags: review?(jwwang) → review+
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d129ab0b9a8c
I think try server got something wrong..., will try again.
Try again and the outcome looks good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52d60019ee3a

Thanks for the review!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9bffb578e423
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.