1271581 - MDSM::SeekComplted() should use newCurrentTime, instead of GetMediaTime(), to decide the nextState.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Tzuhao Kuo [:kaku]]

Follow bug 1235301 comment 41.

MDSM::SeekCompleted() checks |GetMediaTime() == Duration()...| (https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#1994) to decide the nextState. However, it should instead use the newCurrentTime.

Comment 1

[Tzuhao Kuo [:kaku]]

Sorry, it should be bug 1235301 comment 40.

Comment 2

[Tzuhao Kuo [:kaku]]

Attachment: MozReview Request: Bug 1271581 - use newCurrentTime, instead of GetMediaTime() to decide the nextState; r?jwwang

Review commit: https://reviewboard.mozilla.org/r/51611/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51611/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8750715 [details]
MozReview Request: Bug 1271581 - use newCurrentTime, instead of GetMediaTime() to decide the nextState; r?jwwang

https://reviewboard.mozilla.org/r/51611/#review48415

Comment 4

[Tzuhao Kuo [:kaku]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d129ab0b9a8c
I think try server got something wrong..., will try again.

Comment 5

[Tzuhao Kuo [:kaku]]

Try again and the outcome looks good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52d60019ee3a

Thanks for the review!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9bffb578e423

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9bffb578e423