Closed
Bug 1271581
Opened 9 years ago
Closed 9 years ago
MDSM::SeekComplted() should use newCurrentTime, instead of GetMediaTime(), to decide the nextState.
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: kaku, Assigned: kaku)
References
Details
Attachments
(1 file)
Follow bug 1235301 comment 41.
MDSM::SeekCompleted() checks |GetMediaTime() == Duration()...| (https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#1994) to decide the nextState. However, it should instead use the newCurrentTime.
Assignee | ||
Comment 1•9 years ago
|
||
Sorry, it should be bug 1235301 comment 40.
Assignee: nobody → kaku
Blocks: 1235301
Assignee | ||
Updated•9 years ago
|
Summary: MDSM::SeekComplted() should newCurrentTime, instead of GetMediaTime(), to decide the nextState. → MDSM::SeekComplted() should use newCurrentTime, instead of GetMediaTime(), to decide the nextState.
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51611/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51611/
Attachment #8750715 -
Flags: review?(jwwang)
Comment 3•9 years ago
|
||
Comment on attachment 8750715 [details]
MozReview Request: Bug 1271581 - use newCurrentTime, instead of GetMediaTime() to decide the nextState; r?jwwang
https://reviewboard.mozilla.org/r/51611/#review48415
Attachment #8750715 -
Flags: review?(jwwang) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d129ab0b9a8c
I think try server got something wrong..., will try again.
Assignee | ||
Comment 5•9 years ago
|
||
Try again and the outcome looks good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52d60019ee3a
Thanks for the review!
Keywords: checkin-needed
Keywords: checkin-needed
Comment 7•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•