Closed
Bug 1271590
Opened 8 years ago
Closed 8 years ago
NetBSD: timespecadd conflict
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: wiz, Assigned: wiz)
Details
Attachments
(1 file, 1 obsolete file)
|
1023 bytes,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:46.0) Gecko/20100101 Firefox/46.0 Build ID: 20160502172042 Steps to reproduce: NetBSD's sys/time.h defines a timespecadd() macro (since 1996). This breaks compilation of ConditionVariable.cpp which defines a static timespecadd function, but includes the header. Renaming the function to some slightly different name fixes the problem.
Attachment #8750723 -
Attachment is patch: true
Attachment #8750723 -
Attachment mime type: text/x-c++src → text/plain
Attachment #8750723 -
Flags: review?(jdemooij)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8750723 [details] [diff] [review] Patch renaming timespecadd to moz_timespecadd. Review of attachment 8750723 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense, but please fix the filename (ConditionVariable.cpp instead of ConditionVariable.cpp.orig)
Attachment #8750723 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•8 years ago
|
||
Name fixed as requested, no other change to previous version.
Attachment #8750723 -
Attachment is obsolete: true
Attachment #8750755 -
Flags: review?(jdemooij)
|
|
||
Updated•8 years ago
|
Attachment #8750755 -
Flags: review?(jdemooij) → review+
|
|
||
Updated•8 years ago
|
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d7408a1b68cb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•