Tab.loadFavicon(): On failure discard explicit URL instead of first one

NEW
Unassigned

Status

()

Firefox for Android
Favicon Handling
2 years ago
2 years ago

People

(Reporter: sebastian, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
Tab.java: If loading a favicon failed we discard its URL from the list of available favicons.

However we are always discarding the first one:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/Tab.java#463

While this favicon URL was the first one when we initiated the load, it doesn't need to be the first one after the load has failed. In fact when starting the load we even assume that the one we load might not be the first one (anymore):
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/Tab.java#431-445

We should explicitly discard the URL we just tried to load.
(Reporter)

Comment 1

2 years ago
Not yet
Assignee: s.kaspari → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.