Closed Bug 1271709 Opened 3 years ago Closed 3 years ago

eslint-plugin-mozilla .eslintrc is out of date

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

Attachments

(1 file)

testing/eslint-plugin-mozilla/lib/rules/.eslintrc references the obsolete
rule "space-before-keywords", but the top-level .eslintignore means this
isn't readily visible.  I overcame my appreciation for the irony of this
situation enough to write a patch.
testing/eslint-plugin-mozilla/lib/rules/.eslintrc used the obsolete
"keyword-spacing" rule.  This patch fixes that and changes the top-level
.eslintignore so that local eslint rules are now checked.

Review commit: https://reviewboard.mozilla.org/r/51683/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51683/
Attachment #8750864 - Flags: review?(pbrosset)
Comment on attachment 8750864 [details]
MozReview Request: Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r=pbro

https://reviewboard.mozilla.org/r/51683/#review49139
Attachment #8750864 - Flags: review?(pbrosset) → review+
Comment on attachment 8750864 [details]
MozReview Request: Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51683/diff/1-2/
Attachment #8750864 - Attachment description: MozReview Request: Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r?pbro → MozReview Request: Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r=pbro
A deletion snuck in there that caused a try failure.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/34e794136824
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.