1271709 - eslint-plugin-mozilla .eslintrc is out of date

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Tom Tromey :tromey]

testing/eslint-plugin-mozilla/lib/rules/.eslintrc references the obsolete
rule "space-before-keywords", but the top-level .eslintignore means this
isn't readily visible.  I overcame my appreciation for the irony of this
situation enough to write a patch.

Comment 1

[Tom Tromey :tromey]

Attachment: MozReview Request: Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r=pbro

testing/eslint-plugin-mozilla/lib/rules/.eslintrc used the obsolete
"keyword-spacing" rule.  This patch fixes that and changes the top-level
.eslintignore so that local eslint rules are now checked.

Review commit: https://reviewboard.mozilla.org/r/51683/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51683/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8750864 [details]
MozReview Request: Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r=pbro

https://reviewboard.mozilla.org/r/51683/#review49139

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8750864 [details]
MozReview Request: Bug 1271709 - fix eslint-plugin-mozilla .eslintrc; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51683/diff/1-2/

Comment 4

[Tom Tromey :tromey]

A deletion snuck in there that caused a try failure.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34e794136824

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34e794136824

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/34e794136824