Closed Bug 1271759 Opened 4 years ago Closed 4 years ago

Detect and reject machines without SSE2

Categories

(Firefox :: Installer, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 blocking fixed

People

(Reporter: gps, Assigned: robert.strong.bugs)

References

Details

Attachments

(2 files, 3 obsolete files)

Firefox will be dropping support for running without SSE.

The installer should detect when the machine doesn't have SSE available and refuse to install.

bsmedberg: I /think/ this is the requirement you alluded to in email. Please chime in if I'm wrong.
Clarification: we plan on requiring SSE2.
Assignee: nobody → robert.strong.bugs
Summary: Detect and reject machines without SSE → Detect and reject machines without SSE2
Attached image Screenshot of error message (obsolete) —
Attachment #8754600 - Flags: ui-review?(shorlander)
Comment on attachment 8754600 [details]
Screenshot of error message

So, the current string is
Sorry, $BrandShortName can't be installed. This version of $BrandShortName requires ${MinSupportedVer} or newer.

Where ${MinSupportedVer} is either 
"Microsoft Windows XP SP2"
for x86 based systems or
"Microsoft Windows 7 x64"
for x64 based systems.

Note: ${MinSupportedVer} is defined in a non localized file which allows us to change it for all locales without updating the string in all locales.

Since the installer changes are needed for Firefox 49 we can go with a new string but I'd like to have the SSE part defined as we do for ${MinSupportedVer}.
Attached patch patch rev1 (obsolete) — Splinter Review
Matt, I'll submit a followup patch for the string changes and combine the patches into one before landing.
Attachment #8754636 - Flags: review?(mhowell)
Attachment #8754636 - Flags: review?(mhowell) → review+
Tracking for 49 as it is critical.
Attached image Screenshots of messages
Attachment #8754600 - Attachment is obsolete: true
Attachment #8754600 - Flags: ui-review?(shorlander)
Comment on attachment 8757074 [details]
Screenshots of messages

Note: I got approval of the strings, etc. from shorlander
Attachment #8757074 - Flags: ui-review+
Attached patch patch - ui changes rev1 (obsolete) — Splinter Review
Patch that applies on top of patch rev1. I'll attach a patch of the 2 combined as well.

I am going with the latest release system requirements page for now and when a link that redirects to the latest system requirements page for other channels is created I'll change the urls in a new bug.
Attachment #8757099 - Flags: review?(mhowell)
Attached patch combined patchSplinter Review
It might be easier to just review the combined patch.

Note: I'll remove the system requirements check in InstallOnInitCommon in another bug since it will require updating all apps that use InstallOnInitCommon.
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
Note: bug 1276106 will add urls for beta and aurora but doesn't block this from landing. I'll file a new bug for changing the urls and bug 1276106 will block that bug.
Attachment #8757099 - Flags: review?(mhowell) → review+
Comment on attachment 8757100 [details] [diff] [review]
combined patch

Landed the combined patch
Attachment #8757100 - Flags: review+
Attachment #8757099 - Attachment is obsolete: true
Attachment #8754636 - Attachment is obsolete: true
Filed
SeaMonkey bug 1276324
Thunderbird bug 1276320
Instantbird bug 1276325
https://hg.mozilla.org/mozilla-central/rev/eec76f75c79a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.