Update color of a pressed item in the long-press back history menu

VERIFIED FIXED in Firefox 47

Status

()

Firefox for Android
General
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

unspecified
Firefox 49
All
Android
Points:
---

Firefox Tracking Flags

(firefox47 verified, firefox48 verified, firefox49 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

The menu when you long-press the back button to bring up the history and the color when press on one of the menu items – it looks too dark.

Anthony, is toolbar_grey_pressed correct?
Flags: needinfo?(alam)
Created attachment 8750984 [details]
example with toolbar_grey_pressed
Created attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/51729/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51729/
Assignee: nobody → michael.l.comella
(In reply to Michael Comella (:mcomella) from comment #0)
> The menu when you long-press the back button to bring up the history and the
> color when press on one of the menu items – it looks too dark.
> 
> Anthony, is toolbar_grey_pressed correct?

you are correct sir!
Flags: needinfo?(alam)
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51729/diff/1-2/
Attachment #8750987 - Flags: review?(ahunt)

Comment 5

2 years ago
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

https://reviewboard.mozilla.org/r/51729/#review48867
Attachment #8750987 - Flags: review?(ahunt) → review+
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

Approval Request Comment
[Feature/regressing bug #]: Unknown.
[User impact if declined]: Users will see an inconsistent color for the long-press history menu – the same background color is used on the toolbar, but the pressed state is lighter.
[Describe test coverage new/current, TreeHerder]: Local.
[Risks and why]: Low – we copy an existing color file that does what we want (so it shouldn't be broken), swap out a color, and change the background of this view to the new file.
[String/UUID change made/needed]: None
Attachment #8750987 - Flags: approval-mozilla-beta?
Attachment #8750987 - Flags: approval-mozilla-aurora?

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/70b53120eb18
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Created attachment 8752172 [details]
Screenshot from 2016-05-13 15:18:10.png

Tested using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 49.0a1 (2016-05-13)
status-firefox49: fixed → verified

Updated

2 years ago
status-firefox47: --- → affected
status-firefox48: --- → affected
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

Fix was verified on Nightly, Aurora48+, Beta47+
Attachment #8750987 - Flags: approval-mozilla-beta?
Attachment #8750987 - Flags: approval-mozilla-beta+
Attachment #8750987 - Flags: approval-mozilla-aurora?
Attachment #8750987 - Flags: approval-mozilla-aurora+

Comment 11

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/083385f30a43
status-firefox48: affected → fixed

Comment 12

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/f26255003a58
status-firefox47: affected → fixed

Comment 13

2 years ago
Created attachment 8753256 [details]
Screenshot_2016-05-17-11-28-17.png

Tested using:
Device: Huawei Honor (Android 5.1.1)
Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)

Updated

2 years ago
status-firefox47: fixed → verified
status-firefox48: fixed → verified

Comment 14

2 years ago
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.