Closed Bug 1271805 Opened 4 years ago Closed 4 years ago

Update color of a pressed item in the long-press back history menu

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 49
Tracking Status
firefox47 --- verified
firefox48 --- verified
firefox49 --- verified

People

(Reporter: mcomella, Assigned: mcomella)

Details

Attachments

(4 files)

The menu when you long-press the back button to bring up the history and the color when press on one of the menu items – it looks too dark.

Anthony, is toolbar_grey_pressed correct?
Flags: needinfo?(alam)
Assignee: nobody → michael.l.comella
(In reply to Michael Comella (:mcomella) from comment #0)
> The menu when you long-press the back button to bring up the history and the
> color when press on one of the menu items – it looks too dark.
> 
> Anthony, is toolbar_grey_pressed correct?

you are correct sir!
Flags: needinfo?(alam)
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51729/diff/1-2/
Attachment #8750987 - Flags: review?(ahunt)
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

https://reviewboard.mozilla.org/r/51729/#review48867
Attachment #8750987 - Flags: review?(ahunt) → review+
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

Approval Request Comment
[Feature/regressing bug #]: Unknown.
[User impact if declined]: Users will see an inconsistent color for the long-press history menu – the same background color is used on the toolbar, but the pressed state is lighter.
[Describe test coverage new/current, TreeHerder]: Local.
[Risks and why]: Low – we copy an existing color file that does what we want (so it shouldn't be broken), swap out a color, and change the background of this view to the new file.
[String/UUID change made/needed]: None
Attachment #8750987 - Flags: approval-mozilla-beta?
Attachment #8750987 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/70b53120eb18
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Tested using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 49.0a1 (2016-05-13)
Comment on attachment 8750987 [details]
MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt

Fix was verified on Nightly, Aurora48+, Beta47+
Attachment #8750987 - Flags: approval-mozilla-beta?
Attachment #8750987 - Flags: approval-mozilla-beta+
Attachment #8750987 - Flags: approval-mozilla-aurora?
Attachment #8750987 - Flags: approval-mozilla-aurora+
Tested using:
Device: Huawei Honor (Android 5.1.1)
Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.