Closed
Bug 1271805
Opened 8 years ago
Closed 8 years ago
Update color of a pressed item in the long-press back history menu
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox47 verified, firefox48 verified, firefox49 verified)
VERIFIED
FIXED
Firefox 49
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(4 files)
192.02 KB,
image/png
|
Details | |
58 bytes,
text/x-review-board-request
|
ahunt
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details |
71.19 KB,
image/png
|
Details | |
271.98 KB,
image/png
|
Details |
The menu when you long-press the back button to bring up the history and the color when press on one of the menu items – it looks too dark. Anthony, is toolbar_grey_pressed correct?
Flags: needinfo?(alam)
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51729/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51729/
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → michael.l.comella
Comment 3•8 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #0) > The menu when you long-press the back button to bring up the history and the > color when press on one of the menu items – it looks too dark. > > Anthony, is toolbar_grey_pressed correct? you are correct sir!
Flags: needinfo?(alam)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8750987 [details] MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/51729/diff/1-2/
Attachment #8750987 -
Flags: review?(ahunt)
Comment 5•8 years ago
|
||
Comment on attachment 8750987 [details] MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt https://reviewboard.mozilla.org/r/51729/#review48867
Attachment #8750987 -
Flags: review?(ahunt) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/70b53120eb1820043a1739afb2e1574645b92ac3 Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8750987 [details] MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt Approval Request Comment [Feature/regressing bug #]: Unknown. [User impact if declined]: Users will see an inconsistent color for the long-press history menu – the same background color is used on the toolbar, but the pressed state is lighter. [Describe test coverage new/current, TreeHerder]: Local. [Risks and why]: Low – we copy an existing color file that does what we want (so it shouldn't be broken), swap out a color, and change the background of this view to the new file. [String/UUID change made/needed]: None
Attachment #8750987 -
Flags: approval-mozilla-beta?
Attachment #8750987 -
Flags: approval-mozilla-aurora?
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/70b53120eb18
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 9•8 years ago
|
||
Tested using: Device: Nexus 6 (Android 6.0) Build: Firefox for Android 49.0a1 (2016-05-13)
Updated•8 years ago
|
status-firefox47:
--- → affected
status-firefox48:
--- → affected
Comment on attachment 8750987 [details] MozReview Request: Bug 1271805 - Update color of pressed item in the long-press back history menu. r=ahunt Fix was verified on Nightly, Aurora48+, Beta47+
Attachment #8750987 -
Flags: approval-mozilla-beta?
Attachment #8750987 -
Flags: approval-mozilla-beta+
Attachment #8750987 -
Flags: approval-mozilla-aurora?
Attachment #8750987 -
Flags: approval-mozilla-aurora+
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/083385f30a43
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f26255003a58
Comment 13•8 years ago
|
||
Tested using: Device: Huawei Honor (Android 5.1.1) Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)
Updated•8 years ago
|
Comment 14•8 years ago
|
||
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•