The default bug view has changed. See this FAQ.

[FlyWeb] Expose the server URL in addition to server hostname

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: sicking, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8750985 [details] [diff] [review]
Patch to fix

This patch adds FlyWebConnectedService.url in addition to FlyWebConnectedService.hostname.

The patch also adds the wiring to make the 'uiUrl' argument to publishServer work using the standard 'path' TXT record to mDNS.

The change to nsDNSServiceInfo.cpp is needed because otherwise we end up with the properties in the nsIPropertyBag containing nsIVariant objects rather than strings. I.e. we end up with the nsIPropertyBag containing nsIVariants containing nsIVariants containing strings, whereas what we want is a nsIPropertyBag containing nsIVariants containing strings.
Attachment #8750985 - Flags: review?(kvijayan)

Comment 1

11 months ago
Comment on attachment 8750985 [details] [diff] [review]
Patch to fix

Review of attachment 8750985 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/flyweb/FlyWebService.cpp
@@ +103,5 @@
>    nsClassHashtable<nsStringHashKey, DiscoveredInfo> mServiceMap;
>  };
>  
> +void
> +LogDNSInfo(nsIDNSServiceInfo* aServiceInfo, const char* aFunc)

Nice.
Attachment #8750985 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/projects/larch/rev/ab8e3119ea328137ce822c7b29c6e4282fa7e5b4
Bug 1271807: Add support for uiUrl argument to publishServer. r=djvj
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED

Updated

11 months ago
Blocks: 1228662
You need to log in before you can comment on or make changes to this bug.