[FlyWeb] Expose the server URL in addition to server hostname

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sicking, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8750985 [details] [diff] [review]
Patch to fix

This patch adds FlyWebConnectedService.url in addition to FlyWebConnectedService.hostname.

The patch also adds the wiring to make the 'uiUrl' argument to publishServer work using the standard 'path' TXT record to mDNS.

The change to nsDNSServiceInfo.cpp is needed because otherwise we end up with the properties in the nsIPropertyBag containing nsIVariant objects rather than strings. I.e. we end up with the nsIPropertyBag containing nsIVariants containing nsIVariants containing strings, whereas what we want is a nsIPropertyBag containing nsIVariants containing strings.
Attachment #8750985 - Flags: review?(kvijayan)
Comment on attachment 8750985 [details] [diff] [review]
Patch to fix

Review of attachment 8750985 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/flyweb/FlyWebService.cpp
@@ +103,5 @@
>    nsClassHashtable<nsStringHashKey, DiscoveredInfo> mServiceMap;
>  };
>  
> +void
> +LogDNSInfo(nsIDNSServiceInfo* aServiceInfo, const char* aFunc)

Nice.
Attachment #8750985 - Flags: review?(kvijayan) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Blocks: 1228662
You need to log in before you can comment on or make changes to this bug.