Closed Bug 1271853 Opened 4 years ago Closed 4 years ago

[gn] Search engine setup for Firefox Mobile for Guaraní.

Categories

(Mozilla Localizations :: gn / Guarani, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: delphine, Assigned: delphine)

References

()

Details

(Keywords: productization)

Attachments

(1 file, 3 obsolete files)

We want to ship Firefox Mobile with a good list of search engines for Guaraní. 

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Alcides and team, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google, Yahoo, Bing, Amazon, Twitter, Wikipedia

We may also want to go with just a subset of the en-US engines, if that's more appropriate for the local market.

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. We'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed.  Consider using a mobile version of the engine if one is available. For Android we'll want a specific 96x96px image, with colored background and rounder corners (6px radius).

Once we have a specification on what the search engines for Guaraní should look like, Delphine and the localization team will work on the implementation. Delphine will create and attach patches for the desired changes and get them reviewed. After a successful review, Delphine will land them. Huber, if you're interested, you could create the patches, too. You'd ask Delphine for review on those before landing. 

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by flod, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The Guaraní team and Delphine will be driving this bug to completion.
Blocks: fm-l10n-gn
Alcides: any updates/comments on the above please? Waiting for some input from you and your community. thanks!
Flags: needinfo?(torresgutt)
Hi friends! You can use the same search engines as for USA. I mean google, wikipedia, Amazon and Twitter are the most popular here.
Ok thanks! After the hackathon we are all in, I will take care of this and put the ones you have already in desktop :)
Flags: needinfo?(torresgutt) → needinfo?(lebedel.delphine)
Attached patch bug1271853.patch (obsolete) — Splinter Review
Flags: needinfo?(lebedel.delphine)
Attachment #8758050 - Flags: review?(francesco.lodolo)
Comment on attachment 8758050 [details] [diff] [review]
bug1271853.patch

Review of attachment 8758050 [details] [diff] [review]:
-----------------------------------------------------------------

Almost there, only a couple of things to fix.

::: mobile/searchplugins/list.txt
@@ +1,3 @@
> +amazondotcom
> +bing
> +eBay

Drop this line, there is no eBay available on mobile and we're also having some issues with the one on desktop
http://hg.mozilla.org/mozilla-central/file/tip/mobile/locales/en-US/searchplugins/list.txt

@@ +3,5 @@
> +eBay
> +google
> +twitter
> +wikipedia-gn
> +yahoo-es

Let's call the file yahoo-espanol, since it uses espanol.yahoo.com and not es.yahoo.com
Attachment #8758050 - Flags: review?(francesco.lodolo) → review-
Attachment #8758050 - Attachment is obsolete: true
Attachment #8758401 - Attachment is obsolete: true
Attachment #8758401 - Flags: review?(francesco.lodolo)
Attached patch bug1271853v1.patch (obsolete) — Splinter Review
Attachment #8758469 - Flags: review?(francesco.lodolo)
Hi people! I just talked with Alcides, it would be ok, when we use the same search engines as in the desktop version: google, wikipedia in Guarani, amazon.
Comment on attachment 8758469 [details] [diff] [review]
bug1271853v1.patch

Review of attachment 8758469 [details] [diff] [review]:
-----------------------------------------------------------------

On Bugzilla the patch looks good, but I can't import it in the repository. 

Did you edit the .patch file directly? It looks like you modified the part regarding list.txt manually (the number of lines doesn't match the content).

I'd like to have a final check with a working .patch

@huber
We're going with comment 2, which is the same (plus Twitter).
Attachment #8758469 - Flags: review?(francesco.lodolo)
Attachment #8758833 - Flags: review?(francesco.lodolo)
Attachment #8758469 - Attachment is obsolete: true
Attachment #8758833 - Flags: review?(francesco.lodolo) → review+
Pushed https://hg.mozilla.org/releases/l10n/mozilla-aurora/gn/rev/ea1cf0ae63fe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.