1271867 - Update our usage of NSWindow::convertBaseToScreen/convertScreenToBase to modern ApplicationKit API

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jonathan Watt [:jwatt]]

There are a whole bunch of deprecation warnings for usage of NSWindow::convertBaseToScreen/convertScreenToBase when compiling widget code. We should update to modern ApplicationKit API to avoid these warnings.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8751066 [details] [diff] [review]
patch

Review of attachment 8751066 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsCocoaUtils.h
@@ +183,5 @@
>      return NSMakePoint((CGFloat)aPt.x / aBackingScale,
>                         (CGFloat)aPt.y / aBackingScale);
>    }
>  
> +  // Implements an NSPoint equivalent of NSWindow::convertRectFromScreen.

Obj-C method signatures are written as "-[NSWindow convertRectFromScreen:]".

@@ +185,5 @@
>    }
>  
> +  // Implements an NSPoint equivalent of NSWindow::convertRectFromScreen.
> +  static NSPoint
> +  convertPointFromScreen(NSWindow* aWindow, const NSPoint& aPt)

I'd prefer this method to start with an uppercase C. I'd rather have consistency with the other nsCocoaUtils methods than with the convertRectFromScreen method it calls.

@@ +192,5 @@
> +  }
> +
> +  // Implements an NSPoint equivalent of NSWindow::convertRectToScreen.
> +  static NSPoint
> +  convertPointToScreen(NSWindow* aWindow, const NSPoint& aPt)

same here

Comment 3

[Markus Stange [:mstange]]

This is using a 10.7+ API, so let's not accidentally uplift the patch.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bade5f18dc94

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bade5f18dc94