Closed Bug 1271955 Opened 4 years ago Closed 3 years ago

Strip leading and trailing C0 controls and space for urls passed to new URL()

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: 446240525, Assigned: valentin)

Details

(Whiteboard: [necko-active] btpp-active)

Attachments

(1 file)

Strip leading and trailing C0 controls and space for urls passed to new URL()
11.77 KB, patch
mcmanus
: review+
Details | Diff | Splinter Review 
>new URL("\0http://mozilla.org\1")
TypeError:  is not a valid URL // \0 and \1 should be stripped first

spec: https://url.spec.whatwg.org/#concept-basic-url-parser
Seems like we might call into the wrong entry point for the URL parser?
Assignee: nobody → valentin.gosu
Whiteboard: [necko-active]
Whiteboard: [necko-active] → [necko-active] btpp-active
MozReview-Commit-ID: B7BiKE6P7GA
Attachment #8754426 - Flags: review?(mcmanus)
Comment on attachment 8754426 [details] [diff] [review]
Strip leading and trailing C0 controls and space for urls passed to new URL()

Review of attachment 8754426 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for taking this on
Attachment #8754426 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a10683e0ed001963fcf87a55d42b9e189fd4f481
Bug 1271955 - Strip leading and trailing C0 controls and space for urls passed to new URL() r=mcmanus
https://hg.mozilla.org/mozilla-central/rev/a10683e0ed00
https://hg.mozilla.org/mozilla-central/rev/08111f812323
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.