1272040 - Heartbeat action code results in low to 0 survey responses

Status: RESOLVED FIXED

(Shield :: Actions, defect)

Description

[Osmose [:osmose, :mkelly]]

Tyler reported this morning that we hadn't received any survey responses on either of the live heartbeat surveys since 4pm the day before. We had updated the heartbeat action a few hours before the last survey response (https://github.com/mozilla/normandy-actions/compare/68295da7ccd36a528a5a607e266924de49f30ff5...master is what was updated).

I reverted to the previous version of the action and we began to see responses again. This strongly suggests a bug in those changes that is causing users to not get offered the survey.

Comment 1

[Michael Cooper [:mythmon]]

For history, here is a permanent version of the change URL above: https://github.com/mozilla/normandy-actions/compare/mozilla:68295da...mozilla:b5b3ede

Comment 2

[Osmose [:osmose, :mkelly]]

Staging is currently showing a JS error when trying to run Heartbeat recipes: 

TypeError: i.plugins is undefined

Based on that, I believe the root of why surveys weren't getting responses is because Heartbeat wasn't running due to the server-side portion of bug 1264386 not being merged to the backports branch before we deployed the updated action code. 

I'm still trying to get a reliable verification in before marking this as resolved, but I've already cherry-picked the commit to the backports branch: https://github.com/mozilla/normandy/commit/04f61576d14b55bcbc7a8a5e12a7a8ec6656fcc8

Comment 3

[Osmose [:osmose, :mkelly]]

https://normandy-admin.stage.mozaws.net/en-US/repair/ is now working correctly after the backported commit has been deployed to stage, I'm calling this fixed. It'll be deployed next Tuesday. :D