1272057 - API17 guard is required to use Location::getElapsedRealtimeNanos()

Status: RESOLVED FIXED

(Cloud Services :: Server: Location, defect)

Description

[Victor Ng [:vng] [:crankycoder]]

This is a port of the bug from https://github.com/mozilla/MozStumbler/issues/1792 

and patch from https://github.com/mozilla/MozStumbler/pull/1793

Comment 1

[Victor Ng [:vng] [:crankycoder]]

Attachment: bug1272057.patch

This is a port of the patch from https://github.com/mozilla/MozStumbler/pull/1793/files

Comment 2

[Victor Ng [:vng] [:crankycoder]]

This patch is required to fix a bug introduced in bug1259598

Comment 3

[Victor Ng [:vng] [:crankycoder]]

This patch is required to fix a bug introduced in bug1259598

Comment 4

[Hanno Schlichting]

Comment on attachment 8752373 [details] [diff] [review]
bug1272057.patch

Review of attachment 8752373 [details] [diff] [review]:
-----------------------------------------------------------------

You got the wrong commits into this patch again, this includes offline geo code.

Comment 5

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8752373 [details] [diff] [review]
bug1272057.patch

Review of attachment 8752373 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, as above. Please clean-up the dom/geo code from all those watchpoints, thanks!:)

Comment 6

[Victor Ng [:vng] [:crankycoder]]

Attachment: Diff from the try server

Comment 7

[Victor Ng [:vng] [:crankycoder]]

Comment on attachment 8754031 [details] [diff] [review]
Diff from the try server

This diff comes from the try server.

Comment 8

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8754031 [details] [diff] [review]
Diff from the try server

Review of attachment 8754031 [details] [diff] [review]:
-----------------------------------------------------------------

Please double-check the patch as I'm not really sure it builds...:)
Other than those two nits, r=me.

::: mobile/android/stumbler/java/org/mozilla/mozstumbler/service/stumblerthread/datahandling/StumblerBundle.java
@@ +154,5 @@
>  
> +        long gpsTimeSinceBootInMS = 0;
> +
> +        if (Build.VERSION.SDK_INT >= 17) {
> +            gpsTimeSinceBootInMS = mGpsPosition.getElapsedRealtimeNanos()/1000000);

I think you may want to double-check this. ;)

Also a nit: it'd look more consistent with the surrounding code to surround the / operator with a space.

@@ +165,5 @@
>              wifiEntry.put("signal", s.level);
>  
> +            if (Build.VERSION.SDK_INT >= 17) {
> +                long wifiTimeSinceBootInMS = (s.timestamp / 1000);
> +                long ageMS =  wifiTimeSinceBootInMS - gpsTimeSinceBootInMS;

nit: spacing.

Comment 9

[Victor Ng [:vng] [:crankycoder]]

Attachment: Finally. a proper patch.

Comment 10

[Victor Ng [:vng] [:crankycoder]]

Treeherder results of the try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=359f128849e8

Comment 11

[Hanno Schlichting]

Comment on attachment 8754521 [details] [diff] [review]
Finally.  a proper patch.

Review of attachment 8754521 [details] [diff] [review]:
-----------------------------------------------------------------

Finally ;)

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/be24ee25a35b

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be24ee25a35b