Closed Bug 1272066 Opened 8 years ago Closed 8 years ago

Telemetry is apparently not threadsafe.

Categories

(Core :: DOM: Workers, defect)

Product:
Core
Component:
DOM: Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: KWierso, Assigned: baku)

References

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

telemetry.patch
1.21 KB, patch
bkelly
: review+
Details | Diff | Splinter Review 
Landed https://hg.mozilla.org/integration/mozilla-inbound/rev/a3a8e4f9cd21 to hopefully stop it from asserting until a better fix can land.
Keywords: leave-open
Is this a duplicate of bug 1258183 ?
Flags: needinfo?(jseward)
(In reply to Andrea Marchesini (:baku) from comment #4)
> Is this a duplicate of bug 1258183 ?

Yes, I think it is.  Bug 1258183 may not entirely de-race Telemetry, but it is a
good start.  There may be followups depending on whether any remaining Telemetry
races are observed with TSan after bug 1258183 lands.
Flags: needinfo?(jseward)
Whiteboard: btpp-active
Depends on: 1258183
Attached patch telemetry.patch — — Splinter Review 
It seems that all the dependences are now resolved.
I would like to enable this telemetry ID in runnables.
Attachment #8804203 - Flags: review?(bkelly)
Attachment #8804203 - Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a794352cf9c
Add telemetry for sync worker runnables, r=bkelly
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/5a794352cf9c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: